Giter Club home page Giter Club logo

Comments (3)

Ortham avatar Ortham commented on September 16, 2024

AppVeyor have now updated to VS 15.7, so there's no blocker on this now.

from libloot.

Ortham avatar Ortham commented on September 16, 2024

While writing tests for this change, I've realised that the single-argument path constructor that takes a string doesn't handle character encoding as boost::filesystem::path did, as it assumes that a char-based string uses the native narrow encoding, which isn't UTF-8 on Windows, so paths get mangled if constructed that way.

There is an overload that takes string, locale, which uses the given locale to perform character encoding conversion. This works correctly if passed a locale that's been created with Boost.Locale to have UTF-8 support, but otherwise fails. We currently set the global locale using Boost.Locale, so that's not much of an issue, but that does mean relying on gobal state.

The best option is to use std::filesystem::u8path() to construct paths from UTF-8 strings. This doesn't rely on supplying a locale, it only requires the input string to be UTF-8, which the API already expects of all its strings.

Unfortunately, this means I have to go through the existing code looking for everywhere it uses the path string constructor, including when it's done implicitly, like when passing as function arguments and appending as path components. There's a lot of code to go through...

from libloot.

Ortham avatar Ortham commented on September 16, 2024

Done as of fa37dc6.

from libloot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.