Comments (3)
AppVeyor have now updated to VS 15.7, so there's no blocker on this now.
from libloot.
While writing tests for this change, I've realised that the single-argument path constructor that takes a string doesn't handle character encoding as boost::filesystem::path
did, as it assumes that a char
-based string uses the native narrow encoding, which isn't UTF-8 on Windows, so paths get mangled if constructed that way.
There is an overload that takes string, locale
, which uses the given locale to perform character encoding conversion. This works correctly if passed a locale that's been created with Boost.Locale to have UTF-8 support, but otherwise fails. We currently set the global locale using Boost.Locale, so that's not much of an issue, but that does mean relying on gobal state.
The best option is to use std::filesystem::u8path()
to construct paths from UTF-8 strings. This doesn't rely on supplying a locale, it only requires the input string to be UTF-8, which the API already expects of all its strings.
Unfortunately, this means I have to go through the existing code looking for everywhere it uses the path string constructor, including when it's done implicitly, like when passing as function arguments and appending as path components. There's a lot of code to go through...
from libloot.
Done as of fa37dc6.
from libloot.
Related Issues (20)
- Plugin::LoadsArchive() logic doesn't account for more recent games HOT 1
- File::GetDisplayName() falls back to file name HOT 2
- Error message for incorrect use of % HOT 1
- Cyclic interaction detected between ccbgssse002-exoticarrows.esl and ccbgssse002-exoticarrows.esl HOT 7
- Allow matching locale codes against just language code HOT 3
- Update location.rst
- Update localised_content.rst
- Add support for a "detail" property on File objects HOT 1
- Add API function to serialise a given plugin's metadata HOT 1
- Cache plugin name regex objects HOT 2
- Document support for not-expressions HOT 1
- libloot release archive naming HOT 2
- Migrate from using boost::format to std::format (via fmt) HOT 1
- Rework how group edges are added HOT 5
- Add GameInterface::GetType() and GameInterface::GetDatabase() const methods HOT 1
- Use plugins' masters to inform sorting HOT 2
- Allow creation of game handles with local paths that do not exist HOT 1
- needing help to install on arch
- fatal error when trying to build HOT 12
- Exception when loading the masterlist of Fallout New Vegas HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libloot.