Giter Club home page Giter Club logo

Comments (2)

Ortham avatar Ortham commented on August 13, 2024

The API functions affected by load order caching are:

  • GameInterface::LoadPlugins() (also called as part of GameInterface::SortPlugins())
  • GameInterface::IsPluginActive()
  • GameInterface::GetLoadOrder()
  • GameInterface::SetLoadOrder()
  • DatabaseInterface::EvalLists()
  • DatabaseInterface::GetGeneralMessages() (if evaluating conditions)
  • DatabaseInterface::GetPluginMetadata() (if evaluating conditions)
  • DatabaseInterface::GetPluginUserMetadata() (if evaluating conditions)

Loading state in Game (which implements GameInterface) isn't a problem as it has access to the load order handler, but ApiDatabase (which implements DatabaseInterface) doesn't.

LoadPlugins() should always reload state itself, as it's an expensive operation that then caches active states.

The other methods (apart from EvalLists(), which can't reload state anyway) may be assumed to be quick getters operating on cached data, but clients may want to reload the state without reloading plugins or setting the load order, so there should be a new API function for doing so.

For LOOT's usage, it should be enough to rely on the reloading in LoadPlugins(), as plugins are always loaded before (re)initialising any other data.

from libloot.

Ortham avatar Ortham commented on August 13, 2024

Done as of d60d964

from libloot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.