foreign key column has different dataType with its primary key about loopback-connector-mysql HOT 5 CLOSED

or,

  "properties": {
    "id": {
      "type": "number",
      "dataType": "bigint",
      "id": true
    }
  }

Since in modern websites, it will has more than max value 2147483647 of int(11) rows data in a table in one or two years. If it is bigint(20) from beginning, it will cost less effect in future.

However, if I set dataType as bigint, The PK will be bigint(20), but the FK will be int(11).

After searching, I found this commit : loopbackio/loopback-datasource-juggler@4515491
but the pkType in this commit is "string", "number", etc which are without length.

Should I define the columns' types by sql instead of the automigrate? Or which part of codes & document I should read?

Thanks,
Echo

from loopback-connector-mysql.

I think that has been fixed by https://github.com/strongloop/loopback-datasource-juggler/blob/master/lib/datasource.js#L1712-L1717. We now also take the DB specific mapping to the FK. Can you double check?

from loopback-connector-mysql.

Thanks for your quick response.

This line https://github.com/strongloop/loopback-datasource-juggler/blob/master/lib/datasource.js#L1713

  var foreignMeta = this.columnMetadata(foreignClassName, key);

foreignMeta will be always null,

There are two reasons:

a) key is not right value here. It is className's column name instead of foreignClassName's column name.
e.g. 'user' has many 'userIdentity' and the foreignKey is 'userId'.

In this line code, it is

  //foreignClassName is user and key is userId in this place
  var foreignMeta = this.columnMetadata('user', 'userId');  

But it is not right. It should be .columnMetadata('user', 'id');

b) However, even if I consoled this.columnMetadata(foreignClassName, 'id') in this place, but it is still null. I still don't know why...

from loopback-connector-mysql.

For first reason:
the line https://github.com/strongloop/loopback-datasource-juggler/blob/master/lib/datasource.js#L1713 may need to change from

  var foreignMeta = this.columnMetadata(foreignClassName, key);

to

  var foreignMeta = this.columnMetadata(foreignClassName, pkName);

for second reason, I need to understand the columnMetadata code my tomorrow. It is too late at China time now :)

from loopback-connector-mysql.

a) create pull request loopbackio/loopback-datasource-juggler#498

b) after reading https://github.com/strongloop/loopback-example-mysql, when a) is fixing:

to create string PK and make sure the FK is same dataType, the "properties" in model json file should be:

  "properties": {
    "id": {
      "type": "string",
      "id": true,
      "mysql": {
        "dataType": "varchar(30)" 
      }
    }
  }

to create bigint PK , the "properties" should be

  "properties": {
    "id": {
      "type": "number",
      "id": true,
      "mysql": {
        "dataType": "bigint"
      }
    }
  }

from loopback-connector-mysql.