Giter Club home page Giter Club logo

Comments (5)

becky-gilbert avatar becky-gilbert commented on August 16, 2024 1

@msheskin just wanted to let you know that we haven't forgotten about this problem! I'm going to restrict the scope of this particular GH issue to just setting the domain of the Exit URL to match the domain that the researcher is currently using.

Alongside this, we are trying to fix some of the domain/branding consistency issues (lookit.mit.edu vs childrenhelpingscience.com), including this important exit URL / login issue that you've raised. It's not possible to have log in that works for multiple domains, and it would be difficult to use the participant's domain when they're redirected to the study's exit URL. The best solution we've come up with is to create an automatic redirect from the lookit domain to childrenhelpingscience. This means that all existing lookit links will still work, but the URL will automatically change to the CHS domain when someone tries to visit a lookit.mit.edu page. We will be testing this out on the staging server soon to make sure that there aren't any unintended consequences. I can let you know when it's working on the staging site so that you can test things out, if you'd like. I've opened a separate issue to track the domain redirection: #1352

from lookit-api.

becky-gilbert avatar becky-gilbert commented on August 16, 2024

@mekline should we add this to the upcoming production release #1278 ? (It's a very quick change.)

from lookit-api.

mekline avatar mekline commented on August 16, 2024

Yes!

from lookit-api.

becky-gilbert avatar becky-gilbert commented on August 16, 2024

We're leaving this until the next release because I haven't done it yet (focusing on Pipe) and everything else is ready.

Also, just to be clear: this is more of a 'researcher QOL' issue than an important bug. At any point, researchers can change the default exit URL to be the CHS domain (or staging/localhost), it's just a little bit annoying to remember to do this.

from lookit-api.

msheskin avatar msheskin commented on August 16, 2024

Hello! I was about to create a new issue for this topic but I think I can probably leave a comment here instead and then you can let me know if you want me to make this a different issue.

I think there is something here that is NOT just "researcher QOL". Specifically, if a family is logged into ChildrenHelpingScience.com and then the exit URL goes to https://lookit.mit.edu/studies/history they might NOT be logged in at the Lookit URL. And it is possible they have their login credentials saved in their browser for CHS but not for Lookit. The same is true in reverse (a family logged into Lookit who does a study that drops them into https://childrenhelpingscience.com/studies/history might not be logged in there).

This seems like it matters across the site, but will also matter in particular for the GARDEN sequence. We deeply want them to see "the next study" when they are done with each study in the sequence, and so are dropping them into EITHER https://lookit.mit.edu/studies/garden/ OR https://childrenhelpingscience.com/studies/garden/ -- but which one should be the exit URL?

In Becky's Sept 26 comment there is the note "Or a better solution might be to create the study's default Exit URL using the value of SITE_DOMAIN from the project settings." and I'm not sure what "SITE_DOMAIN from the project settings" means, but I think the most elegant solution would be if the exit URL could pay attention to the current URL the family is on. Specifically, the researcher indicates just "/studies/garden" as the exit URL, and then Lookit pays attention to whether the family is at Lookit or CHS URL to fill in the first part.

from lookit-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.