Giter Club home page Giter Club logo

Comments (9)

kuhnroyal avatar kuhnroyal commented on July 24, 2024 1

@LukaGiorgadze we explicitly tried to avoid this version bump of collection in the Dio upgrade branch

from http-mock-adapter.

chunghha avatar chunghha commented on July 24, 2024

Meanwhile I can use 'dependency_overrides' to my troublesome projects' pubspec.yaml.

dependency_overrides:
collection: "1.17.1"

from http-mock-adapter.

LukaGiorgadze avatar LukaGiorgadze commented on July 24, 2024

@chunghha Could you try to update test to the latest version in your pubspec?

from http-mock-adapter.

chunghha avatar chunghha commented on July 24, 2024

@LukaGiorgadze I believe typically projects have this set with "flutter_test" as the below which uses collection.

flutter_test:
sdk: flutter

That means collection version from sdk should be set with http_mock_adapter.

I set my projects with minimum sdk version 2.19.0 so collection 1.17.0 matches with. If someone else wants a. lower minimum sdk version then probably setting the collection version to 1.15.0 is the safe bet as @kuhnroyal pointed in the review of dio v5 PR.

https://pub.dev/packages/collection/changelog

from http-mock-adapter.

kuhnroyal avatar kuhnroyal commented on July 24, 2024

Yes the problem is that flutter enforces a certain collection version. Stable (Flutter 3.7) is on collection: 1.16.0 but if you want some form of backward compatibility then the library should target 1.15.0.

from http-mock-adapter.

LukaGiorgadze avatar LukaGiorgadze commented on July 24, 2024

@chunghha @kuhnroyal
According to Flutter's official Github, it seems that they have an updated version of the collection (1.7.1).
https://github.com/flutter/flutter/blob/master/packages/flutter_test/pubspec.yaml#L35

Could you try flutter update-packages ?

I'm okay to revert it back, but I want to make sure that you have guys the latest versions of flutter + packages that depend on the collection.

from http-mock-adapter.

chunghha avatar chunghha commented on July 24, 2024

I concur with what @kuhnroyal wrote about the backward compatibility.

I have the latest Flutter stable sdk version 3.7.3 installed, so with flutter_test from the sdk version, collection 1.7.0 is installed for my project. Then I got to override the version to 1.7.1 in the pubspec.yaml in order for me to install http_mock_adapter 0.4.0 because it requires the 1.7.1.

from http-mock-adapter.

LukaGiorgadze avatar LukaGiorgadze commented on July 24, 2024

I guess downgrading collection to 1.16.0 in http_mock_adapter can solve that problem so there won't be any incompatibility. How does it sound? @chunghha @kuhnroyal

from http-mock-adapter.

LukaGiorgadze avatar LukaGiorgadze commented on July 24, 2024

Take a look at this PR #142

from http-mock-adapter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.