Investigate including VST3 SDK as a submodule about wavesabre HOT 14 CLOSED

agreed about submodules; a custom script is likely much easier to use/work with.

from wavesabre.

submodules are notoriously hard to work with, and I would recommend against using them unless it provides a lot of benefit over something else.

It's the ugly duckling that was added to Git simply so KDE could convert their SVN repo that used svn:external heavily, but then nobody really gave it the love that was needed... It's not really something that should have been in Git in the first place IMO.

from wavesabre.

Unfortunately, we still need to support VST3 in order to do this (#89), as even the earliest tagged VST3 SDK releases on Github don't include any of the VST2 SDK code.

from wavesabre.

If this isn't possible then a "hack" would be to in a build setup use wget/curl or something like that to fetch and unpack it.

from wavesabre.

Indeed, we should try to see if that works with this archive link that we currently link to in our docs, and if so, we could provide (platform-specific?) script(s) to set it up more easily.

from wavesabre.

Yeah. For windows it would be possible to just include wget/curl and unzip inside a bin directory, and then have a setup.cmd setup.sh etc that just fetches it.

from wavesabre.

@kusma In this case it might be ok if it's only to fetch the code and never update it, otherwise I agree

from wavesabre.

another problem tho with submodules is that everyone forgets to add --recursive when cloning. Now not a hard problem to fix, but it will be a constant question :)

from wavesabre.

@emoon: It's still pretty awkward to set up the project if you're not online or if github has problems, even if you have both repos already cloned. Submodules don't really do the "distributed" part of "distributed version control"...

from wavesabre.

Right

from wavesabre.

And yeah, I have opted to move away from submodules for most/all of my projects because in the end they are a PITA to work with.

from wavesabre.

It would be possible to use file(DOWNLOAD ...) and file(ARCHIVE_EXTRACT ...) in the CMakeLists.txt to get and unpack the VST3 SDK automatically - that saves the trouble of using scripts (or having the users download it manually).

from wavesabre.

Like this: #92 :)

from wavesabre.

Fixed in #92

from wavesabre.