I am using log4cplus 1.2.0 rc3 now. When I use <code class="notransl

For me, it looks like a bug, too. <div class="highlight highlight-source-c++ notra

I had fix this problem using: remove <code class="notranslate"

I think this is now fixed by <a class="issue-link js-issue-link" data-error-text="Fail

a bug in TimeBasedRollingFileAppender? about log4cplus HOT 4 CLOSED

log4cplus commented on June 18, 2024

a bug in TimeBasedRollingFileAppender?

from log4cplus.

Comments (4)

wilx commented on June 18, 2024

I think this is by design. DailyRollingFileAppender does the same thing since ever (5b6b25a). TimeBasedRollingFileAppender is new and it has inherited the feature from DailyRollingFileAppender. The idea is that if you do not roll the file when you are closing the appender, you will not know what file name to use next time you start your application and need to roll it.

from log4cplus.

artur-shaik commented on June 18, 2024

For me, it looks like a bug, too.

    const char* logPath = logDir.append("%d.log").toStdString().c_str();

    initialize();

    helpers::Properties p;
    p.setProperty(LOG4CPLUS_TEXT("FilenamePattern"), LOG4CPLUS_TEXT(logPath));
    p.setProperty(LOG4CPLUS_TEXT("CleanHistoryOnStart"), LOG4CPLUS_TEXT("false"));
    p.setProperty(LOG4CPLUS_TEXT("CreateDirs"), LOG4CPLUS_TEXT("true"));
    p.setProperty(LOG4CPLUS_TEXT("ImmediateFlush"), LOG4CPLUS_TEXT("true"));
    p.setProperty(LOG4CPLUS_TEXT("DatePattern"), LOG4CPLUS_TEXT("yyyy-MM-dd"));

    const char* pattern = "%-7r [%d{%Y/%m%dT%H:%M:%S.%Q}] %5p [%10.10t] %c <> %m%n";
    SharedTimeBasedRollingFileAppenderPtr fileAppender(new TimeBasedRollingFileAppender(p));
    fileAppender->setName(LOG4CPLUS_TEXT("FileAppender"));
    fileAppender->setLayout(std::auto_ptr<Layout>(new PatternLayout(pattern)));
    Logger::getRoot().addAppender(SharedAppenderPtr(fileAppender.get()));

    if (verbose)
    {
        helpers::SharedObjectPtr<Appender> consoleAppender(new ConsoleAppender());
        consoleAppender->setLayout(std::auto_ptr<Layout>(new PatternLayout(pattern)));
        consoleAppender->setName(LOG4CPLUS_TEXT("ConsoleAppender"));
        Logger::getRoot().addAppender(consoleAppender);
    }

    Logger::getRoot().setLogLevel(getLogLevel(level));

With this setup, on exit log file always empty.

If I add:

    p.setProperty(LOG4CPLUS_TEXT("Filename"), LOG4CPLUS_TEXT(filePath));

On exit patterned log file is always overwrited. Doesn't append to old log file.

Or may be this is wrong approach?

PS For now I have removed rollover call in close() method, and it works as expected for me.

from log4cplus.

sangechen commented on June 18, 2024

I had fix this problem using:

remove rollover() call in close() {TimeBasedRollingFileAppender do not need this rollover behavior, I think}
after rotate log files, re-open new file, do not truncate it! {when File property is missing, TimeBasedRollingFileAppender do not rollover at all. so we cannot truncate any file}

from log4cplus.

wilx commented on June 18, 2024

I think this is now fixed by #123.

from log4cplus.

Recommend Projects