Do not override Backbone.sync about localforage HOT 7 CLOSED

If it’s that simple that works for me. I don’t like the override we do but I haven’t ever built a big Backbone app with multiple sync adapters, so I’m a bit out of my depth on what the best practice is.

from localforage.

I'm sure the current implementation works for most users, but with a little change it can work for everyone. It just occurred to me a simpler usage:

var LocalModel = Backbone.Model.extend({
  sync: Backbone.localforage.sync('storename') // Use a store for the model
});

var OtherLocalModel = Backbone.Model.extend({
  sync: Backbone.localforage.sync() // Use the model's collection store
});

I can send a pull request if there's consensus about this.

from localforage.

Oh wow, I really like that. That would be amazing 👍

from localforage.

I like that as well.

from localforage.

Fixed in ff38f31

from localforage.

I'll fix the Backbone example according to this changes.

from localforage.

I already did, no worries :-)

Matthew Riley MacPherson (Sent from mobile)

On Feb 22, 2014, at 17:32, José Magalhães [email protected] wrote:

I'll fix the Backbone example according to this changes.

—
Reply to this email directly or view it on GitHub.

from localforage.