Crash in sandboxed chrome app. about localforage HOT 5 CLOSED

it works for me, isn't the next code enough for sandboxed chrome app?

if (window.chrome && window.chrome.runtime) {
        return;
}

// Initialize localStorage and create a variable to use throughout the code.
var localStorage = window.localStorage;

from localforage.

sorry, you're right. it was a bug in my chrome app building script

from localforage.

Closed without fix? O really?

from localforage.

@xquezme Sorry, I misread the comments and thought things were working. Sometimes I miss context from reading GitHub emails.

That said, I thought https://github.com/mozilla/localForage/blob/master/src/drivers/localstorage.js#L10 fixed this already?

from localforage.

Either way, I'll push a fix, as I think I'd prefer the try/catch over the window.chrome check, as it's closer to feature detection.

@xquezme In the future, if you'd like to submit a pull request directly (given that you had the code ready in this issue) I would happily accept it. I'm usually faster to merge pull requests than anything else.

from localforage.