LNPBP-2 references to an outdated stage of commitment procedure of LNPBP-1 about lnpbps HOT 2 CLOSED

Actually I wonder if the whole paragraph still makes sense, since it starts with Runs LNPBP-1 commitment protocol on message msg, the selected public key Pand public keyS *with the following modification*, but all those modifications are already described in LNPBP-1:

• Provide HMAC function with S instead of P ==> Compute HMAC-SHA256 of the lnbp1_msg using sum of public keys S.
• the tweaking-factor based point F is added to the P (a single original public key), resulting in key T ==> Add two elliptic curve points: the original public key Po and point F, derived from the tweaking-factor. This will give resulting tweaked public key T: T = Po + F.
• if the number of original public keys defined at step 1 exceeds one, LNPBP2 tag MUST BE used instead of LNPBP1 ==> it seems that it's not the case anymore
• a protocol-specific tag is provided by the upstream protocol using this standard ==> Construct a byte string lnpbp1_msg, composed of the original message prefixed with a single SHA256 hash of LNPBP1 string and a single SHA256 hash of protocol-specific tag

On further reading I noticed more parts that probably need to be update and/or clarified, I made a PR #106 with all this, it will be easier to discuss there.

from lnpbps.

Thank you for catching this up, you are welcome to do a PR with all of this fixes.

1. removing (instead of P)
2. fixing references to steps as you described everywhere
3. remove use of LNPBP2 tag (we are not talking about tag variable from LNPBP1)

from lnpbps.