Giter Club home page Giter Club logo

Comments (59)

Spekular avatar Spekular commented on August 20, 2024

Clean slate sounds good to me. I think it would be good if we had a clear
plan for the wiki structure that we followed to keep it nice and coherent.
EDIT: @lukas-w I was told to ask you for wiki permissions.

from lmms.io.

Sti2nd avatar Sti2nd commented on August 20, 2024

Hahhaa, the SFXR article isn't really too advanced, it is just really hard to understand cause it is more like a fictional text than an informative.

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

I must be missing somehing, because I still have no idea how to login to the wiki @Umcaruje @lukas-w

from lmms.io.

lukas-w avatar lukas-w commented on August 20, 2024

@Spekular I can set you up, just send me a mail with the username and the email address you want to use.

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

@lukas-w can't find your mail address. Can I tell you my desired name and email here or is it secret?

from lmms.io.

Sti2nd avatar Sti2nd commented on August 20, 2024

Not secret, everyone is gonna know your username, and I can already see your mail, so :)

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

@lukas-w Alright well I'd like the same username as here, Spekular, and the same email, [email protected]
EDIT: Referred to the wrong person earlier, oops.

from lmms.io.

lukas-w avatar lukas-w commented on August 20, 2024

You should have received a mail with your password ;)

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

@lukas-w Here comes the hard part! 👍

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

I'll be back soon to keep working on it, but here's what I've done so far on the sfxr page: http://lmms.sourceforge.net/wiki/index.php/SFXR

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

Ok, so I'm almost done with the SFXR page (http://lmms.sourceforge.net/wiki/index.php/SFXR), but there's a few dials I can't figure out. If someone could explain the change, square, and phaser dials, that would be great. (I couldn't hear a difference with square, and I don't know the mechanics behind/reason for the difference in phaser and change.) Also I'm not sure how to exlain filter resonance, as I've never really gotten how it works. @Umcaruje @Sti2nd @lukas-w

from lmms.io.

Sti2nd avatar Sti2nd commented on August 20, 2024

Good work! You are super fast. Someone can probably take a look at the missing things some time (not me right now).
Feedback:

  • We call dials for knobs.
  • The image is now right aligned, I guess because it looks stupid with empty space on the right of the content box, but we either have to change all the other other plugin articles to keep consistency, or keep left alignment. Maybe we should discuss this @Umcaruje

from lmms.io.

Umcaruje avatar Umcaruje commented on August 20, 2024

Ok @Spekular, first of all: nice work! It looks much cleaner now. Now some things you should look at:

  • The Pictures are usually on the right side of the page, not left, so for the sake of the wiki being consistent, please change that.
  • "SFXR is a vst port of the original sfxr" Thats not correct, its actually just a port, it has nothing to do with VST's

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

@Umcaruje Do you mean that the image should be on the left on the sfxr page or should I move the other ones to the right?? And ok, I'll change it so it doesn't mention vsts.

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

Editing my comment on mobile is a pain so I'll make a new one for this:
Personally, I think images should be on the right. Text is anchored on the
left and flows better if it's uninterrupted, so images should be anchored
on the right. With an image on the left the text suddenly jumps out and
then in again. This is also more space efficient as the image can occupy
the same vertical space as the table of contents. I have no issue going
through the wiki and moving images so it's consistent.some images, like
fullscreen screenshots, might look odd anchored on the rigt, but they look
best centered anyways (imo), so they would be an exception either way.

from lmms.io.

Umcaruje avatar Umcaruje commented on August 20, 2024

Hah right anchored images feel very wierd to me, you kinda loose focus from the actual instrument image and you just look at the text. But that's personal preference. I like the old layout of the Preset pages (Image to left) because there is only one image in the article, so it breaks the monotonous text.

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

@Umcaruje I think images to the right is standard, since that's the way it is on Wikipedia and most game wiki's I've been on. When a user is trying to learn LMMS they shouldn't have to "relearn" how to read a wiki. There are some left anchored images on Wikipedia but they are exceptions and much smaller in width than ours. Wide images, like our screenshots, appear to be centered. So should I make the wiki "Wikipedia style", or have it the way it is right now? I don't think EVERY image needs to be on the same side in order for it to be consistent.

from lmms.io.

tresf avatar tresf commented on August 20, 2024

Anchoring to the right and floating out in right field cyberspace are two different things. Some of your content leaves huge white spaces between the text and the image it is describing. Wikipedia is not a software tutorial. It doesn't have hundreds of software screenshots relevant to the text content like a software wiki does. Please keep this in mind when writing the tutorials. If you can have it flow well, the alignment isn't terribly important, but rather flow and consistancy would prevail.

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

@tresf The only content I've done so far is sfxr, and I'm not sure what you mean by floating out in right field? Anyways, I've added lots of images closer to the text in my latest revision, what do you think of it this?

from lmms.io.

Umcaruje avatar Umcaruje commented on August 20, 2024

@Spekular There is a difference here. All of our plugin articles have only one picture. Also, the articles themselves are not really full of text, mostly because its good that they are short and understandable. As Tres said, anchoring to the right leaves huge white spaces, and it just drags the users focus from the image to the text. This isn't about what is the 'standard' , it is about what is good. The other Plugin pages all have one image on the left and it looks good.

Let me compare The SFXR article and The TripleOscillator one (Which is imo one of the best and most consistent plugin articles):

SFXR:
white space

TripleOscilator:
3xosc

This was screen captured on a normal 1080p screen. The TripleOscillator article looks much more solid and consistent.

As for the other articles, they do use right and centered images alongside left ones, and they also look good too.

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

Oh crud. Working on this on the go on a laptop I didn't see how drastic the whitespace was. I think one of the culprits here is the table of content though, I can't seem to make the text start next to it instead of under. I'll try and work on the whitespace issue and report back with another iteration soon. Thanks for the feedback, despite how it may seem I do appreciate it!

Here's what I originally posted:

The thing is, in my opinion, it doesn't look good. That's not to say that my
opinion is the one that matters, just evidence that "what looks good" is
subjective. As for the lack of text in the other articles, that's because
they're more compact and general. If an LMMS user wants to know how a
plugin works, they should go to the wiki page on that plugin. If that wiki
page is just a general overview, tons of info is left for the user to find
out on their own. Being unable to find that info might be the reason they
come to the wiki in the first place, and if we know it, why keep it to
ourselves? As for what the rest of the articles look like, if we wanna keep
the wiki the way it is, why overhaul it in the first place?

from lmms.io.

Umcaruje avatar Umcaruje commented on August 20, 2024

Another thing: The wiki really had a major rehaul several months ago. @Sti2nd and myself have taken and duplicated almost all 0.4 articles and updated them to LMMS 1.0 (Others helped too, like musikbear and mikobuntu). I just made this thread so that the few articles that are left get done, since we have schools and lives and just couldn't finish. Rehaul in the tittle may sound a bit misleading now, but my point was to fix the outdated and incomplete articles, not go and rearrange the existing ones that have been proofread and fixed very recently.

I also wanted to talk about what is going to happen to the old articles, but I guess I'll open a new issue for that.

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

@Umcaruje I suppose I'll anchor the image left and get rid of the other ones, but I'm not entirely sure you'll like that either.

from lmms.io.

Umcaruje avatar Umcaruje commented on August 20, 2024

Why would you delete the other images? I never said anything about that.

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

@Umcaruje someone mentioned the other articles only having one image. I'll keep them then!
EDIT: As I thought, it was you!

All of our plugin articles have only one picture

Anyways here's the updated article. Still looks odd to me :/ I'm now $100% sure the TOC is the culprit for the whitespace!
Alright, so the whitespace issue has little to do with the image in this case. If I remove the TOC the text can flow around the image naturally, but thats not a very good fix. Once I/we have figured out how to let the text flow around the TOC, the left/right issue is all about preference/consistency. I found a mediawiki help page that shows how to make the TOC "float" so text wraps around it, but it requires CSS editing, which I'm unfamiliar with and don't have access to. If someone else could create a {{tocright}} and {{tocleft}} template (instructions here and here) it would be great.
Here's an (admittedly ugly) screenshot with no TOC and the image on the right (I haven't figured out how to make the image "break" headings on the left yet):
notoc right

from lmms.io.

Sti2nd avatar Sti2nd commented on August 20, 2024

i think the solution might lie in using CSS for showing the image, not the image syntax. Copy it from here for example http://lmms.sourceforge.net/wiki/index.php/Opulenz

from lmms.io.

Umcaruje avatar Umcaruje commented on August 20, 2024

The solution Stian presented is actually how most of the plugin pages are done. Its a nice workaround.

from lmms.io.

Sti2nd avatar Sti2nd commented on August 20, 2024

I think it is mostly good that you have made so many headlines, it makes it quick to find what you are looking for. One could debate that it is unnecessary because of just one or two sentence under each headline, but I still think it is slightly better than just a list. It is more text there than on the other plugins :)

from lmms.io.

Sti2nd avatar Sti2nd commented on August 20, 2024

At least with the images you have added it makes sense. If the images hadn't been there, I would have considered it better to make a bulleted list.
Btw: I edited the page to use CSS

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

{| cellspacing="0" valign="top" align="center" width="100%"
| width="300px" style="color: #000" valign="top"|
[[File:Plugins_SFXR1.0.0.png|left]]
| style="color: #000" valign="middle"|

Can you explain this line by line so I know how to edit it/can do it myself on other pages? Also, should the screenshot have a frame around it? It had one earlier, so I kept it.

from lmms.io.

Sti2nd avatar Sti2nd commented on August 20, 2024

It is CSS, what I think it does is creating one table with two rows (or two tables). The first line creates the invisible outer walls of the table, which will cover 100% of the page width, and the two other sentences creates one row each. The image is in the left row, and the text is in the middle row. You don't need to learn CSS, just copy and paste it. There is two things you need to know to use the copy/paste.

  1. you replace the image source.... pretty obvious. No need to add frames or alignments, that is handled by the CSS.
  2. You can see the CSS code starts with an {| , it also ends with an |} . In the articles the end attribute is placed after the text you want to be beside the image.

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

Alright, I'm having serious issues finding out where to fit the TOC in a gracious way. Without it, the subheadings/headings are useless, but it doesn't look good next to the screenshot, it shouldn't be on the right (I tried, looks bad), and the text looks awkward when you put the image on the right instead. The best solution I've found so far is putting it under the screenshot but I don't think that's a good idea. I've updated the page with my (very experimental) changes so you can view them (screenshots are bad, they only show the page in one way), but I've got the "stable" version backed up in a text file so I can easily revert it.
EDIT: I'm also gonna find a better way to have the knobs integrated, as right now they're a bit awkward. Or should I remove them?
EDIT 2: Fixed link, thanks @tresf

from lmms.io.

tresf avatar tresf commented on August 20, 2024

What is wrong with the way we have it now?

http://lmms.sourceforge.net/wiki/index.php/Organic

BTW, your link is broken for people that don't have edit access to the wiki. 🚲

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

@tresf I'm getting a "this wiki has a problem" page. It shows up sometimes, sometimes not. Whats up with that? Anyways, here's some screenshots with the TOC next to the image:
default
flow
more flow
more more flow

from lmms.io.

Sti2nd avatar Sti2nd commented on August 20, 2024

The first one! Or just leave it as it was..

from lmms.io.

tresf avatar tresf commented on August 20, 2024

@Spekular, I don't manage the wiki nor have access to it so I won't help troubleshoot problems with it.

That said, you should be able to flow Overview into its own area by using something like a HR tag or perhaps some custom CSS. 🔧

from lmms.io.

tresf avatar tresf commented on August 20, 2024

Actually, looking at it again, the image and TOC could probably be wrapped into a table or a div, but I've yet to see the wiki markdown so I'm not the one to help with this. 👻

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

@tresf

I don't manage the wiki nor have access to it so I won't help troubleshoot problems with it.

The first part was a general question. The mention was because of the screenshots. Also, the way I did all of these was custom CSS!

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

@Sti2nd when you say "the way it was" do you mean like this?
asis

from lmms.io.

Sti2nd avatar Sti2nd commented on August 20, 2024

No, I added the CSS yesterday, it certainly didn't look like that ✋ The TOC was to the right of the image. You can revert the changes from the history tab on the wiki.

from lmms.io.

Umcaruje avatar Umcaruje commented on August 20, 2024

Or just remove the TOC. Or not use a subheading for each sentence. That could solve it too.

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

@Umcaruje There is a way to make a horizontal TOC, but we haven't implemented a template and IDK how. That could work really well.

47 sentences/9 subheadings = 5.222 sentences per subheading. 29 lines/9 subheadings = 3.222 lines per subheading. 47 sentences/ 15 total headings = 3.133 sentences per heading. 29 lines/15 total headings = 1.933 lines per heading.

from lmms.io.

Sti2nd avatar Sti2nd commented on August 20, 2024

@Spekular Maybe it would, but I don't exactly see how, cause the TOC, and the problem with the TOC on the SFXR page is that it is too long in a vertical list, and I can't picture how that would be as a horizontal one :p Any links which show horizontal TOC?

from lmms.io.

StakeoutPunch avatar StakeoutPunch commented on August 20, 2024

Just wanted to pop in and say that I have started tackling articles that are already written, but could use grammar overhauls. I am almost finished with http://lmms.sourceforge.net/wiki/index.php?title=1.0:Working_with_VSTs

I still have the last two sections to do, as well as making more accurate section headers (the current ones don't follow the article well imo).

As for the SFXR page, @Umcaruje's solution makes the most sense to me. There doesn't need to be a subheading in the TOC for every knob, for example.

from lmms.io.

Sti2nd avatar Sti2nd commented on August 20, 2024

Nice to have an English speaking onboard. <-- From that grammar you see we need it.

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

@Sti2nd Here's a horizontal TOC
@StakeoutPunch Do you have a list of articles that need fixing? Or are you just going though them one by one?

from lmms.io.

StakeoutPunch avatar StakeoutPunch commented on August 20, 2024

@Spekular one by one as needed. I work better without todo lists :)

from lmms.io.

Sti2nd avatar Sti2nd commented on August 20, 2024

Ok, Horizontal could work, but in this case I suspect it will not. Anyway, without TOC as it is now is maybe the best.

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

The sfxr page still needs explanations for the Change, Square, and Phaser knobs, and an explanation of what the reverb knob does in the filter knobs. can anyone explain what these are to me?

from lmms.io.

Sti2nd avatar Sti2nd commented on August 20, 2024

Thank you for reminding me on that. What I did was just play around with it and write down what I found out. I come as far as the change. You can probably read yourself up on the effect phaser and then understand what it does.

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

@Sti2nd that's exactly what I did, haha. The ones left are the ones that I couldn't hear a difference on/understand the difference.

from lmms.io.

tresf avatar tresf commented on August 20, 2024

Don't forget, we can reach out to developers at any time if needed.

Just tag one by name and I'm sure he/she would be happy to explain.

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

@tresf I'm not sure who added sfxr though :/
@Sti2nd So, duplicate the signal, shift the different frequencies a bit with time (all pass filter), combining it with the original signal creates phase cancellation that changes with time (loops), then you modulate the frequency shifting (all pass) as well to get an even weirder effect. That's about what I got from it.

from lmms.io.

tresf avatar tresf commented on August 20, 2024

Wong Cho Ching ported it for us per:

https://github.com/LMMS/lmms/blob/stable-1.1/plugins/sfxr/sfxr.cpp

But Vesa has written some synths, if wong isn't available.

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

@wongcc966422 @diizy could either of you explain the change, square, and phaser knobs in sfxr?

from lmms.io.

SadaleNet avatar SadaleNet commented on August 20, 2024

@Spekular
Square: Options for square wave only.
S.DUTY changes the duty cycle. For example, when the knob is at leftmost, the square wave look like this: _|¯|_|¯|_|¯|_|¯|_|¯|_ . If the knob is in middle, the wave look like this: -╵¯╵-╵¯╵-╵¯╵-╵¯╵-╵¯╵-, notice that the minimum position is shifted up and the top position remains unchanged(sorry for bad ASCII graphic).
S.SPD. is duty sweep. It is the change of duty cycle over time. Example: If it is turned to the right, the minimum wave position shifts up over time.

Phaser: phaser is... well, phaser. IDK how it works exactly. It makes the sound sounds less dull. It's similar to phaser fx, but much simplier.

from lmms.io.

Spekular avatar Spekular commented on August 20, 2024

Ok, I think the sfxr page is pretty much done, if anyone thinks there's missing content tell me. VeSTige doesn't feel done yet, but I'm not sure what more to add. Maybe I should add small screenshots for the icons here as well? ("blue down arrow pointing to a hard drive" is a mouthful to read/understand and the whole thing feels a bit like a wall of text.)

from lmms.io.

tresf avatar tresf commented on August 20, 2024

We shouldn't have two bugs open with the same topic (to merge conversation) so I'm closing this one out as duplicate. Technically this one came first, but the other one has bulleted questions/action items so I'm choosing to close this one.

@Spekular please transfer any outstanding tasks from this bug report that you feel worth mentioning over to the other bug so they aren't lost.

Uros seems to be kicking ass with this topic, so I'm sure we'll be able to close the other thread out soon enough as eventually the wiki will be in maintenance mode and dedicated bug reports will be redundant.

from lmms.io.

tresf avatar tresf commented on August 20, 2024

Closing as duplicate of #99.

from lmms.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.