Giter Club home page Giter Club logo

Comments (15)

lukas-w avatar lukas-w commented on August 20, 2024

How about some small buttons in the footer?
screenshot - 090814 - 11 06 36

from lmms.io.

tresf avatar tresf commented on August 20, 2024

I think it would be easy enough. Do you want to try making the lame colored-labeled ones or keep them plain? We could even do the oversized footer thing that's quite popular these days...
screen shot 2014-08-09 at 9 22 52 am

screen shot 2014-08-09 at 9 23 48 am

from lmms.io.

tresf avatar tresf commented on August 20, 2024

It will also be quite redundant with our community tab, so we can consider making an include w/ a switch to change style as well?

from lmms.io.

Sti2nd avatar Sti2nd commented on August 20, 2024

I agree on that you can hide those buttons if you want.

from lmms.io.

lukas-w avatar lukas-w commented on August 20, 2024

I suggest removing the links from the community dropdown. I also think they're evil, a regular menu item (assumingly part of the sitemap) should not link to external sites. I was surprised by that a lot when I first clicked it.

Do you want to try making the lame colored-labeled ones or keep them plain?

I vote for plain, color makes them more important than they really are ;)

We could even do the oversized footer thing that's quite popular these days...

As long as we have enough content to fill such a giant footer, I'm not opposed to the idea.

from lmms.io.

Umcaruje avatar Umcaruje commented on August 20, 2024

I have been playing around a bit and this is how I imagine the buttons:
social
If you like the idea, I could make a pull request.

from lmms.io.

tresf avatar tresf commented on August 20, 2024

That is cool! How do the numbers get updated?

from lmms.io.

Umcaruje avatar Umcaruje commented on August 20, 2024

Well I used mdo's Github buttons and Facebook's official like button, so they get updated whenever there's a new like or star. I would have put a count to the G+ button too, but its too wide compared to the others when I do so.

from lmms.io.

tresf avatar tresf commented on August 20, 2024

Hmmmm... Yeah we use thier API with credentials as to not exceed the daily
usage limits and that example seems like a quick hack someone created.

If I'm reading it correctly, his solution uses JavaScript to read the JSON
data on each page refresh.

Our approach uses PHP to read cached JSON data from the local web server
which refreshes every 15 minutes.

So if my assumptions are correct, his solution could break quickly on a
high traffic site like ours.

Furthermore, we have those bootstrap styles already in bootstrap.min.js so
perhaps an approach which mimics his but doesn't bombard the GitHub servers
would he the best of two evils.

I haven't ported any of the existing JSON feeds to to JS yet, and we make
our feeds private so JS can't read them either so we'll have to shim
something into json_common.php to get the same results.

Currently the feed updates block the page load so I've removed them from
the front page. If we crontab these feeds (again not implemented) and
sanitize and expose them publicly via PHP, then I think we would have an
ideal scenario.

from lmms.io.

tresf avatar tresf commented on August 20, 2024

So short answer, if we do this let's roll our own. :)

from lmms.io.

lukas-w avatar lukas-w commented on August 20, 2024

Please don't ever use facebook's like button on our official website! There are major privacy issues with it (it violates privacy laws in Germany and Canada for instance). Here are some links about it.

So if my assumptions are correct, his solution could break quickly on a
high traffic site like ours.

As the mdo's buttons use Javascript, the queries are sent from each visitor's browser/computer, so this wouldn't break anything for users except for those who visit our sites a hundred times per second, correct?

Nevertheless, I have been playing around with this as well a week ago. But because of the facebook privacy issues and because I didn't like the iframe way mdo's GitHub buttons work, I decided to just include boring links instead of buttons.

So I agree, if we're going to make buttons, we should make our own ;)

from lmms.io.

tresf avatar tresf commented on August 20, 2024

On Aug 16, 2014 1:02 PM, "Lukas W" [email protected] wrote:

Please don't ever use facebook's like button on our official website!
There are major privacy issues with it (it violates privacy laws in Germany
and Canada for instance). Here are some links about it.

Thx for the info.

As the mdo's buttons use Javascript, the queries are sent from each
visitor's browser/computer, so this wouldn't break anything for users
except for those who visit our sites a hundred times per second, correct?

Ah good point. In my testing 10 in a minute can trigger this (all services
seem to intentionally leave rate limits secret) but good points nonetheless.

from lmms.io.

lukas-w avatar lukas-w commented on August 20, 2024

If 10 in a minute are enough to reach the limit we should indeed roll our own. ;)

from lmms.io.

Umcaruje avatar Umcaruje commented on August 20, 2024

You guys have really valid points. I never knew that about the facebook button. Interesting.
Well, looks like the best way is that we make our own buttons.

from lmms.io.

tresf avatar tresf commented on August 20, 2024

We have a verified site via Google+. Closing.

image

from lmms.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.