lmeulen / asusroutermonitor Goto Github PK

I have noticed that the app crashes intermittently when iterating over clnts['get_clientlist']. It seems like it's undefined sometimes.

I've made a fix for this that I can push in a feature-branch if you want.

Best / J

Stacktrace:

Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/flask/app.py", line 2292, in wsgi_app
response = self.full_dispatch_request()
File "/usr/lib/python3/dist-packages/flask/app.py", line 1815, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/jeth/.local/lib/python3.7/site-packages/flask_cors/extension.py", line 165, in wrapped_function
return cors_after_request(app.make_response(f(*args, **kwargs)))
File "/usr/lib/python3/dist-packages/flask/app.py", line 1718, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/usr/lib/python3/dist-packages/flask/_compat.py", line 35, in reraise
raise value
File "/usr/lib/python3/dist-packages/flask/app.py", line 1813, in full_dispatch_request
rv = self.dispatch_request()
File "/usr/lib/python3/dist-packages/flask/app.py", line 1799, in dispatch_request
return self.view_functionsrule.endpoint
File "/home/jeth/apps/asus-router-monitor-rest/app.py", line 45, in onlineClients
return ar.get_online_clients()
File "/home/jeth/apps/asus-router-monitor-rest/asus_router.py", line 262, in get_online_clients
for c in clnts['get_clientlist']:
KeyError: 'get_clientlist'

seems it works only via lan. It can be http or https. Script uses only http.
If you want to use external ip you will get message
"Only HTTPS is supported when accessing the web UI from WAN."
also there are different ports of 80.
Changing port is not a problem, but i dont know how to deal with certificates via python. So the script dosnt work

Would you consider changing get_lan_ip_adress to get_lan_ip_address?

Hi,

First of all thanks for you code.
in line 257, you assumed that 'isOnline' is available. But in somecases it's missing.
if (len(c) == 17) and (clnts['get_clientlist'][c]['isOnline'] == '1'):

So, it is better to check if the key is present. then go for filtering:
if (len(c) == 17) and "isOnline" in clnts['get_clientlist'][c]:

BTW, I am no coder. just a hobbiest. There may be a better way to handle missing 'isOnline' key.

I will use your code to create a telegram bot and send a message if a new client is associated in network.

Thanks.