Comments (6)
Yes, this is something we have to do. I just locally reverted the StructAttr
removing patches since the fix is somewhat non-trivial. I plan on getting to that at some point in the next few weeks.
from clangir.
Uhh, it was accidently closed by my mobile device (
from clangir.
@inclyc the only thing he did was to revert the commit that "changed the deprecation into the actual remove of StructAttr
", and that revert is already in the repo (no local unpushed work), once code is changed not to use StructAtt
we will undo the revert. So it's still pretty much open if you feel like taking this :)
from clangir.
Thanks for documenting the issue @inclyc, on top of what @lanza said, we also welcome patches in case this is something you'd like to fix :)
Cheers!
from clangir.
Thanks for documenting the issue @inclyc, on top of what @lanza said, we also welcome patches in case this is something you'd like to fix :)
Cheers!
Hi @bcardosolopes , seems @lanza has made patches locally and to avoid any duplicated work I'm looking for some other issue.
from clangir.
from clangir.
Related Issues (20)
- Improve StructType documentation
- Add an aliases for mutable types in CIR
- Fix error message with `!IntegerType`s. HOT 6
- Destroy objects at end of scope HOT 7
- Loop with `break` or `continue` at top level but not last statement fails validation HOT 1
- Loop with `break` or `continue` as last statement causes assertion failure
- Failed verification of struct attribute with pointer-to-array initializer HOT 3
- Make "scoped" regions somehow explicit
- Fix XFAIL in clang/test/CIR/CodeGen/vbase.cpp HOT 1
- Fix windows builds to unblock test infra
- Re-introduce tablegen constraint for "is-this-a-CIR-type" and use it here
- Add support for clang-format-action after next rebase
- Destructors are not called when jumping out of a scope
- Statement expression dtor issue
- Invalid LLVM for constant array reference HOT 3
- Make most CIRGenTypeCache types to be MLIR type aliases
- Fix XFAILs on Lowering/globals.cir and CodeGen/fun-ptr.c HOT 2
- Use dedicated string attribute for string literals
- How should cir.base_class_addr work
- Make `cir.array` types mutable to allow forward declarations
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clangir.