Comments (4)
Thanks for catching this. @sitio-couto seems like you are going to hit this sooner or later!
from clangir.
Probably the best way to fix this is to scan body region inside CIRLoopLowering, replacing break/continue yields with BrOps?
We did this and it seems to work fine. I think we should be able to send PR in few days if you are ok with this approach.
from clangir.
We did this and it seems to work fine. I think we should be able to send PR in few days if you are ok with this approach.
PRs are great :)
For full context, ideally we should lower those to a more simple form of CIR before LLVM lowering happens, so we can keep LLVM lowering a bit more simple. However, there are other changes we'd need before that in general and looks like your approach would work for now, so I'm ok with it. Let's just make sure you and @sitio-couto coordinate a bit to prevent dup work (we're also on discord if you'd like to discuss any other aspect).
from clangir.
Let's just make sure you and @sitio-couto coordinate a bit to prevent dup work
@yugr I haven't reached unstructured loops yet. Feel free to work on this!
from clangir.
Related Issues (20)
- LLVM 17.0.X tagged release. HOT 5
- Add support for vector types HOT 6
- Initial support for OpenMP HOT 4
- Initial support for OpenACC HOT 4
- C/C++ atomic types and operations HOT 3
- Create a github action for testing CIR HOT 2
- Support for TBAA HOT 2
- Implement bool->int and bool->float conversions HOT 2
- Codegen ignores global variable offsets in initializers HOT 1
- Improve StructType documentation
- Add an aliases for mutable types in CIR
- Fix error message with `!IntegerType`s. HOT 6
- Destroy objects at end of scope HOT 7
- Loop with `break` or `continue` at top level but not last statement fails validation HOT 1
- Loop with `break` or `continue` as last statement causes assertion failure
- Failed verification of struct attribute with pointer-to-array initializer HOT 3
- Make "scoped" regions somehow explicit
- Fix XFAIL in clang/test/CIR/CodeGen/vbase.cpp HOT 1
- Fix windows builds to unblock test infra
- Re-introduce tablegen constraint for "is-this-a-CIR-type" and use it here
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clangir.