Giter Club home page Giter Club logo

Comments (4)

bcardosolopes avatar bcardosolopes commented on July 20, 2024 1

Thanks for catching this. @sitio-couto seems like you are going to hit this sooner or later!

from clangir.

yugr avatar yugr commented on July 20, 2024 1

Probably the best way to fix this is to scan body region inside CIRLoopLowering, replacing break/continue yields with BrOps?

We did this and it seems to work fine. I think we should be able to send PR in few days if you are ok with this approach.

from clangir.

bcardosolopes avatar bcardosolopes commented on July 20, 2024

We did this and it seems to work fine. I think we should be able to send PR in few days if you are ok with this approach.

PRs are great :)

For full context, ideally we should lower those to a more simple form of CIR before LLVM lowering happens, so we can keep LLVM lowering a bit more simple. However, there are other changes we'd need before that in general and looks like your approach would work for now, so I'm ok with it. Let's just make sure you and @sitio-couto coordinate a bit to prevent dup work (we're also on discord if you'd like to discuss any other aspect).

from clangir.

sitio-couto avatar sitio-couto commented on July 20, 2024

Let's just make sure you and @sitio-couto coordinate a bit to prevent dup work

@yugr I haven't reached unstructured loops yet. Feel free to work on this!

from clangir.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.