Lowering of nested break/continue in loops about clangir HOT 4 CLOSED

Thanks for catching this. @sitio-couto seems like you are going to hit this sooner or later!

from clangir.

Probably the best way to fix this is to scan body region inside CIRLoopLowering, replacing break/continue yields with BrOps?

We did this and it seems to work fine. I think we should be able to send PR in few days if you are ok with this approach.

from clangir.

We did this and it seems to work fine. I think we should be able to send PR in few days if you are ok with this approach.

PRs are great :)

For full context, ideally we should lower those to a more simple form of CIR before LLVM lowering happens, so we can keep LLVM lowering a bit more simple. However, there are other changes we'd need before that in general and looks like your approach would work for now, so I'm ok with it. Let's just make sure you and @sitio-couto coordinate a bit to prevent dup work (we're also on discord if you'd like to discuss any other aspect).

from clangir.

Let's just make sure you and @sitio-couto coordinate a bit to prevent dup work

@yugr I haven't reached unstructured loops yet. Feel free to work on this!

from clangir.