Comments (6)
As of now, the withName
method is case sensitive by design, so that there are no surprises when coming from the standard lib Enumeration
and because I think it makes sense (no pun intended). Convoluted example; in a Drinks
enum, coke
may not be the same as Coke
.
That said, I'm open to the idea of making withName
optionally case insensitive, such as via an optional parameter caseInsensitive
parameter that defaults to false
.
from enumeratum.
What about an import? This is what I've used in a few projects to soften the impact of throwing an exception when trying to parse incoming data I don't control.
import scalaz.Monoid
object SafeEnumeration {
implicit final class SafeEnumerationReads[E <: Enumeration](val enum: E) extends AnyVal {
def safeWithName(name: String): Option[E#Value] = enum.values.find(_.toString equalsIgnoreCase name)
def withNameOrZero(name: String)(implicit m: Monoid[E#Value]): E#Value = safeWithName(name) getOrElse m.zero
}
}
Then it's really easy to use both methods on some enumeration.
object FacebookProfileCategory extends Enumeration {
val `Musician/Band` = Value("Musician/Band")
val Company = Value("Company")
val Other = Value("Other")
implicit val categoryMonoid = new Monoid[Value] {
def zero = Other
def append(x: Value, y: => Value) = ???
}
}
from enumeratum.
Wow, that is pretty cool :) I like the way you used implicits and monoids to make it slick.
However, I think introducing a separate method 1. that doesn't throw and 2. allows for case-insensitive matching might be a better compromise here because then we can cache the case-insensitive map (faster) and it is easier to use for end-users.
e.g. On Enum[A]
trait Enum[A] {
lazy val caseInsensitiveNamesToValuesMap: Map[String, A] = values map (v => v.toString.toLowerCase -> v) toMap
def withNameOption(name: String, caseInsensitive: Boolean = false): Option[A] = {
if (caseInsensitive)
caseInsensitiveNamesToValuesMap get name.toLowerCase
else
namesToValuesMap get name
}
}
What do you think?
from enumeratum.
Not bad, maybe the boolean should be two methods?
from enumeratum.
Done !
from enumeratum.
Cool thanks!
On Mar 6, 2015 12:26 AM, "Lloyd" [email protected] wrote:
Done !
—
Reply to this email directly or view it on GitHub
#5 (comment).
from enumeratum.
Related Issues (20)
- Avoid the use of `toString` for `enumEntry`? HOT 4
- [Scala 2] Compile-time stackoverflow with lots of enum values HOT 3
- Version 1.7.2 is not binary compatible with previous versions HOT 2
- Conflict with Scala 3 enums HOT 5
- Breaking compatibility should trigger a major version update HOT 2
- .
- enumeratum-json4s not available for Scala3? HOT 7
- Scala3: findValues fails to compile in nested sealed trait hierarchy HOT 1
- Scala 3: findValues fails to find entries extending types with type parameters HOT 1
- How to upgrade enumeratum-doobie to target v1.0.0-RC4 HOT 3
- Un-sealed abstract class in hierarchy gets ignored on Scala 3.x HOT 1
- Support play-json 3.0.x
- Members of enums nested in a class are not discovered in scala 3 HOT 1
- Derived `CirceEnum` codecs fail roundtrip on `case class` values HOT 4
- Enumeratum-Play 1.8.0 with Play 3 and Pekko cannot find play.api.libs.json.KeyReads at runtime HOT 2
- Override a single entry with custom name HOT 4
- ScalaDoc warnings in any code using the library
- Circe: Allow to decode enumerations more relaxed HOT 3
- Scala 3 ValueEnum only finds values if the value constructor parameter is first HOT 5
- Doobie 1.0.0-rc5 required HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from enumeratum.