sundials 5.1 does not build on windows with mingw about sundials HOT 13 CLOSED

Ah will try

from sundials.

We also apply this patch on Windows for KLU, in case it makes sense upstreaming. Just pointing it out here:

https://github.com/JuliaPackaging/Yggdrasil/blob/master/S/Sundials%405/bundled/patches/Sundials_windows.patch

FYI, I will see about getting this patch in sundials.

from sundials.

@ViralBShah We included a bug fix in our v5.2.0 release that should fix this issue. If it does not, please reopen this ticket.

from sundials.

cc @jd-lara

from sundials.

I think there is a missing -DBUILD_SUNDIALS_LIBRARY in one of the CMake files. Note also that in the log there are a lot of warnings like

[02:40:11] /workspace/srcdir/sundials-5.1.0/src/sundials/sundials_linearsolver.c:28:17: warning: ‘SUNLinSolNewEmpty’ redeclared without dllimport attribute: previous dllimport ignored [-Wattributes]
[02:40:11]  SUNLinearSolver SUNLinSolNewEmpty()
[02:40:11]                  ^~~~~~~~~~~~~~~~~

I can build if I manually do

export CFLAGS="-DBUILD_SUNDIALS_LIBRARY"

before calling cmake.

from sundials.

@giordano It does appear that -DBUILD_SUNDIALS_LIBRARY is missing somewhere. Can you try setting the CMake variable CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS to TRUE instead of setting BUILD_SUNDIALS_LIBRARY in CFLAGS?

from sundials.

We also apply this patch on Windows for KLU, in case it makes sense upstreaming. Just pointing it out here:

https://github.com/JuliaPackaging/Yggdrasil/blob/master/S/Sundials%405/bundled/patches/Sundials_windows.patch

from sundials.

@balos1 The CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS does not work, and gives the same linking error:

https://dev.azure.com/JuliaPackaging/Yggdrasil/_build/results?buildId=1498&view=logs&j=0c8f16f8-c0df-5cf3-8178-b591b90f12cf&t=fdd4b889-5821-506e-6c2a-64b809c5b85c&l=3913

from sundials.

@ViralBShah CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS is a CMake variable, not a definition for the compiler. It looks like the build you linked had set this in the CFLAGS variable that is given to the compiler. Instead, when you invoke cmake you want to do cmake -DCMAKE_WINDOWS_EXPORT_ALL_SYMBOLS=True <other options>.

from sundials.

Ah will try

@ViralBShah Was the build successful?

from sundials.

We haven't try with your new suggestion yet, since we have some upstream problems with SuiteSparse at the moment.

from sundials.

Thank you. At this point we are getting Sundials 5.1 integrated into Julia and we'll stabilize that and then move to 5.2. At that point if there's still an issue, we'll reopen.

from sundials.

@balos1 We just tried without the workaround and it wasn't successful at building in WIndows.

JuliaPackaging/Yggdrasil#701 (comment)

from sundials.