Using C++17 and compiler flags <code class="notransla

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Closed by PR <a class="issue-link js-issue-link" data-error-text="Failed to load title

Narrowing conversion in Ginko about hiop HOT 7 CLOSED

nychiang commented on July 28, 2024

Narrowing conversion in Ginko

from hiop.

Comments (7)

pelesh commented on July 28, 2024

Does explicitly casting n_ to unsigned integer before passing it to Ginkgo resolves the issue?

from hiop.

nychiang commented on July 28, 2024

Yes, manually casting those variables work fine. Now everything works on Newell.
However, on Marianas, I got the following error from different places :

people/svcexasgd/gitlab/126079/src/LinAlg/hiopLinSolverSparseGinkgo.cpp:175:42: error: 'using Array = class gko::array<double>' is deprecated: please use array [-Werror=deprecated-declarations]
  175 |     auto val_array = gko::Array<double>::view(exec, nnz_, kVal_);
      |                                          ^~~~
In file included from /qfs/projects/exasgd/src/ci-deception/linux-centos7-zen2/gcc-10.2.0/ginkgo-1.5.0.glu_experimental-3o5dw4rvskf3bkknmfzth252ybr4crcf/include/ginkgo/ginkgo.hpp:41,
                 from /people/svcexasgd/gitlab/126079/src/LinAlg/hiopLinSolverSparseGinkgo.hpp:55,
                 from /people/svcexasgd/gitlab/126079/src/LinAlg/hiopLinSolverSparseGinkgo.cpp:55:
/qfs/projects/exasgd/src/ci-deception/linux-centos7-zen2/gcc-10.2.0/ginkgo-1.5.0.glu_experimental-3o5dw4rvskf3bkknmfzth252ybr4crcf/include/ginkgo/core/base/array.hpp:717:7: note: declared here
  717 | using Array [[deprecated("please use array")]] = array<ValueType>;

Any suggestion?

@fritzgoebel @pelesh @cnpetra

from hiop.

cnpetra commented on July 28, 2024

maybe avoid deprecated call?

from hiop.

fritzgoebel commented on July 28, 2024

I am working on updating the Ginkgo interface and will get rid of the deprecated call in the process.

from hiop.

nychiang commented on July 28, 2024

@fritzgoebel Thanks for taking care of this. In fact, I tried to fix it in PR #654. Right now it passes all the designed pipeline tests. Please have a look of it, as it is ready for merge.

@cnpetra

from hiop.

fritzgoebel commented on July 28, 2024

Sorry, I was not aware of the PR. Looks good to me.

from hiop.

nychiang commented on July 28, 2024

Closed by PR #654 @cnpetra

from hiop.

Recommend Projects