What needs to be done after subclassing EchemSolver? about echemfem HOT 2 OPEN

The only method that needs to be implemented in all cases is set_boundary_markers. The other methods are set_velocity if using advection, neumann if using a Neumann BC, and poisson_neumann if using a Neumann BC for the Poisson equation. In each case, their use is mentioned in documentation (where advection or boundary conditions are discussed). Regardless, the use of abstract base class was introduced early in the development, and its uses have stayed rather limited. All other methods have obvious defaults and parameters are actually being set through arguments. Is this limited use of abstract base class too confusing?

As mentioned in Issue #11 , examples need to be better documented. Their structure could also be improved, and input files could be introduced as well.

from echemfem.

Okay wonderful, thanks for the clarification. I will wait for the resolution of #11 in that case, thanks!

from echemfem.