Support for Web Push Payload Encryption about php-gcm HOT 4 OPEN

Yes, it should be pretty easy to encrypt the payload before it is sent based on some optional parameters.

If you'd like to take a stab at implementing it, I'd be happy to review and provide some feedback for a pull request.

from php-gcm.

Hello @lkorth, we have implemented some properties on the Message class (publicKey, salt, rawData) with getters and setters.

We have then modified the Sender to intercept those properties (only if set) and add appropriate headers:

Encryption: salt=<SALT>
Crypto-Key: dh=<PUBLICKEY>
Content-Encoding: aesgcm

and body field for the notification request (as explained here):

{
    "registration_ids": [ "…" ],
    "raw_data": "BIXzEKOFquzVlr/1tS1bhmobZ…"
}

This way your library can be used to send encrypted messages without having to encrypt them: is up to the user to give a correct rawData content.

Here an example:

$message = new Message();
$message->publicKey($publicKey);
$message->salt($salt);
$message->rawData(base64_encode($encryptedPayload));

If you are interested we'll make a pull request. At the moment we have implemented it above your latest stable release but it's not hard to port it to the developer one.

from php-gcm.

If you'd like to make a PR with those changes, that would be awesome! If you're already encrypting the data, would you consider adding a method to the Message class for encrypting data? When it builds the message, if the public key and salt are present it could just encrypt it for you.

A few things have moved around in the Sender class, but it should be trivial to update to include the headers. The only other change that I see off hand is just making the functions on Message chainable.

Let me know if I can clarify anything, otherwise I look forward to reviewing the PR.

from php-gcm.

We will create the PR as soon as possible. Unfortunately the encryption stuff is really complex and we are using code from an external library (WebPush) that depends from many other libraries.

So we have decided to decouple the payload handling stuff from the encryption tasks to ease the PR. Please take a look at their code, maybe you can use it to implement the same stuff in your library in future.

from php-gcm.