Giter Club home page Giter Club logo

Comments (6)

axelboc avatar axelboc commented on June 16, 2024 1

Awesome, thanks ^^

from eslint-config-galex.

ljosberinn avatar ljosberinn commented on June 16, 2024

seeing the issue, its something stupid. fix in the works

from eslint-config-galex.

ljosberinn avatar ljosberinn commented on June 16, 2024

should be fixed with 717d3b0

from eslint-config-galex.

ljosberinn avatar ljosberinn commented on June 16, 2024

confirmed to work on my machine ™️

from eslint-config-galex.

axelboc avatar axelboc commented on June 16, 2024

Awesome, thanks, good catch!

First error is gone -- but now I'm getting another one with the overrides:

Type 'WithOverrideType<OverrideESLintConfig> | null' is not assignable to type 'ConfigOverride<RulesRecord>'.
  Type 'null' is not assignable to type 'ConfigOverride<RulesRecord>'.

create<React|...>Override can return null but it seems that the type of the overrides property does not allow for that. I could cast, or move the creation of the override out of the createConfig call and add a non-null assertion, or add the overrides to the array conditionally, but this is obviously not ideal.

  overrides: [
    createReactOverride({
      ...dependencies,
      rules: { ... },
    }),
  ]

from eslint-config-galex.

ljosberinn avatar ljosberinn commented on June 16, 2024

thanks, should be fixed in latest version; I've tested with your config here to confirm its working :)

from eslint-config-galex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.