Giter Club home page Giter Club logo

Comments (6)

hkockerbeck avatar hkockerbeck commented on June 30, 2024

I looked into the issue a bit further, and it looks like you need to require the "base ActiveSupport" in addition to the part you want to use. See for example the Rails guides on ActiveSupport Extensions. A short trial run in pry also supports this:

[1] pry(main)> require 'active_support/core_ext/string/inflections'
=> true
[2] pry(main)> ActiveSupport::VERSION::MAJOR
NameError: uninitialized constant ActiveSupport::VERSION
from (pry):2:in `__pry__'

compared to

[1] pry(main)> require 'active_support'
=> true
[2] pry(main)> require 'active_support/core_ext/string/inflections'
=> true
[3] pry(main)> ::ActiveSupport::VERSION::MAJOR
=> 5

So I'd suggest to add another require to the slug function in markdown_extensions.rb like so

def slug(text)
      require "active_support"
      require "active_support/core_ext/string/inflections"
      if ::ActiveSupport::VERSION::MAJOR >= 5
        ::ActiveSupport::Inflector.parameterize(text, separator: "-")
      else
        ::ActiveSupport::Inflector.parameterize(text, "-")
      end
    rescue LoadError
      text.downcase.gsub(/[ _\.\-!\?\(\)\[\]]+/, "-").gsub(/^-|-$/, "")
end

from livingstyleguide.

hagenburger avatar hagenburger commented on June 30, 2024

Sounds good. Do you want to open a pull request?

from livingstyleguide.

Dahie avatar Dahie commented on June 30, 2024

Hi, any idea when this is going to be release on rubygems? The current version doesn't contain this fix yet. :)

from livingstyleguide.

hagenburger avatar hagenburger commented on June 30, 2024

@Dahie thanks for the reminder. I’ll try to check tonight. I’m not actively using it right now as I’m working on JavaScript projects only. Most of my development goes into PIMD – which is based on the ideas and learnings of LivingStyleGuide. I’d love to have a Ruby integration later on.

from livingstyleguide.

hagenburger avatar hagenburger commented on June 30, 2024

@Dahie done: https://twitter.com/LSGorg/status/1048126173467873280

from livingstyleguide.

Dahie avatar Dahie commented on June 30, 2024

@hagenburger woop woop, thank you! <3

from livingstyleguide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.