Comments (7)
jonatanklosko
commented on June 12, 2024
2
@lkarthee some tests require erlang docs, so we skip them if the local erlang is not compiled with docs, but some tests are missing the annotations. I've just pushed a fix :)
from livebook.
lkarthee
commented on June 12, 2024
1
Can I send PR - from long time I wanted to dive into livebook source ?
from livebook.
josevalim
commented on June 12, 2024
1
@lkarthee yes, please, go for it. it would be lovely to have your contributions here too :)
from livebook.
josevalim
commented on June 12, 2024
I think it disappears because it changes the output type but I am also fine with showing it. Thoughts @jonatanklosko? Are PRs welcome?
from livebook.
jonatanklosko
commented on June 12, 2024
Agreed, it is a different output and it totally makes sense to show it!
from livebook.
jonatanklosko
commented on June 12, 2024
Closed in #2435.
from livebook.
lkarthee
commented on June 12, 2024
On my mac these test fail everytime - do you know why ?
13:17 $ elixir -v
Erlang/OTP 26 [erts-14.1.1] [source] [64-bit] [smp:10:10] [ds:10:10:10] [async-threads:1] [jit]
Elixir 1.16.0 (compiled with Erlang/OTP 26)
13:18 $ mix test
Compiling 1 file (.ex)
Excluding tags: [erl_docs: true, teams_integration: true]
........................................................................................................................................................................................................................................................................................................................................................................................................................................
1) test intellisense completion for remote nodes find modules from apps (Livebook.RemoteIntellisenseTest)
test/livebook/remote_intellisense_test.exs:94
match (=) failed
code: assert [
%{
label: "all_keys/1",
kind: :function,
detail: ":mnesia.all_keys/1",
documentation: _all_keys_doc,
insert_text: "all_keys($0)"
}
] = Intellisense.get_completion_items(":mnesia.all", context, node)
left: [%{detail: ":mnesia.all_keys/1", documentation: _all_keys_doc, insert_text: "all_keys($0)", kind: :function, label: "all_keys/1"}]
right: [
%{detail: nil, documentation: "No documentation available", insert_text: "all_keys($0)", kind: :function, label: "all_keys/1"},
%{label: "all_keys/4", kind: :function, detail: nil, documentation: "No documentation available", insert_text: "all_keys($0)"}
]
stacktrace:
test/livebook/remote_intellisense_test.exs:97: (test)
...........................................................................................................................................................................................................................................................................................
2) test get_details/3 includes type specs (Livebook.IntellisenseTest)
test/livebook/intellisense_test.exs:1491
Assertion with =~ failed
code: assert type =~ "@type load_error_rsn() ::"
left: "[View on Erlang Docs](https://www.erlang.org/doc/man/code.html#type-load_error_rsn)\n\n---\n\nNo documentation available"
right: "@type load_error_rsn() ::"
stacktrace:
test/livebook/intellisense_test.exs:1500: (test)
......................................................................................................................................................................................................................................................................................................................................................................................................................................................
3) test get_details/3 returns module-prepended type signatures (Livebook.IntellisenseTest)
test/livebook/intellisense_test.exs:1479
Assertion with =~ failed
code: assert type =~ ":code.load_error_rsn()"
left: "[View on Erlang Docs](https://www.erlang.org/doc/man/code.html#type-load_error_rsn)\n\n---\n\nNo documentation available"
right: ":code.load_error_rsn()"
stacktrace:
test/livebook/intellisense_test.exs:1488: (test)
..................................................................................................................................
Finished in 27.5 seconds (27.5s async, 0.04s sync)
78 doctests, 1299 tests, 3 failures, 99 excluded
from livebook.
Related Issues (20)
- `nil` autosave location causes option to be missing from HTML on Settings and notebooks are not saved. HOT 4
- Problem with `lb:*` cookies HOT 2
- ImageComponent crashes livebook if passed non-binary `contents` HOT 1
- Race condition on smart cell evaluation HOT 1
- Store app password in stamp encrypted data HOT 4
- Information loss with current variable name binding model (JSON -> Json) HOT 6
- Crash on Windows when trying to save file if a nearby filename contains an emoji HOT 3
- Livebook not working on window 10 HOT 2
- Livebook cannot connect to the default runtime HOT 20
- Deployed apps don't reevaluate cells marked as 'Reevaluates automatically' HOT 6
- Support epmdless runtimes HOT 1
- Cannot drop files on Safari
- Add two options to xlsx_reader? One to skip empty sheets and another to nillify expect_chars? HOT 4
- Revisit teleport integration
- Node terminated unexpectedly HOT 14
- Fix asset cache URL on distributed deployments
- mix escript.install hex livebook (cannot run livebook after) HOT 3
- Request to Acknowledge Uffizzi's Contributions in README HOT 5
- Livebook will not open; due to error during startup HOT 3
- Support Fly for zero-trust authentication HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from livebook.