Giter Club home page Giter Club logo

Comments (4)

josevalim avatar josevalim commented on June 14, 2024 1

I think there are two issues here. One is that we are showing null as top and we should not. Would like to send a PR for that?

the other is to use min/max, but we should probably have a separate discussion for that one. :)

from kino_explorer.

josevalim avatar josevalim commented on June 14, 2024 1

@cristineguadelupe we already show the number of nulls, which together with the number of top entries (besides null) will be enough to distingish if null is actually the most frequent. For example, if this summary said something like:

top: 2020-01-01
top_freq: 324
nulls: 189119

It will be pretty clear nulls is more frequent, so IMO we should show the first non-null top. (also we should rename top_freq: to top freq: :))

from kino_explorer.

cristineguadelupe avatar cristineguadelupe commented on June 14, 2024

One is that we are showing null as top and we should not.

Maybe we should, but obviously not the empty string!

from kino_explorer.

Hanspagh avatar Hanspagh commented on June 14, 2024

I think there are two issues here. One is that we are showing null as top and we should not. Would like to send a PR for that?

Sure

from kino_explorer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.