Giter Club home page Giter Club logo

Comments (3)

hartig avatar hartig commented on July 4, 2024

As in my other comment (see #32 (comment)), to me the array-based approach seems to be more reasonable in general. However, this particular case here is a bit different than the case in #32, because here we really use only one ordering criterion in our query templates. Therefore, for this case, it seems easier to justify the single-object approach.

from lingbm.

chengsijin0817 avatar chengsijin0817 commented on July 4, 2024

Thank, you are right. The array-based approach does give more possibility to some query, it seems that I tried to design more features than needed.
Based on our rule: only add exactly the features that are used in at least one of our query templates. You are right, I will check all issues related to 'array' or 'not array'.
I will let you know when I finished.

from lingbm.

chengsijin0817 avatar chengsijin0817 commented on July 4, 2024

I have changed the schema to the single-object approach:

reviews(order:ReviewSortingCriterion): [Review]

from lingbm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.