Giter Club home page Giter Club logo

Comments (8)

bari86 avatar bari86 commented on May 28, 2024 1

Hi,
I do understand that my example was using the Cartflows plugin, but let think it as a general way to skip cache if needed. Some cache plugin do allow certain slug to skip cache, which might be important to either debug, or certain case scenario. So would be good to allow at least certain pre-defined slug, example 'ex-.' so someone can name it /ex-custompath if needed. this would require just one extra slug in your existing setup, or you can put in some custom txt file that it can refer to but it might complicates thing?

adding custom url in ss-config would be good too but it might takes time to do it. keep up the good work.

from slickstack.

bari86 avatar bari86 commented on May 28, 2024

a really simple solution would be something like add /ex-* so we can just add the path like "ex-" as prefix and viola, no cache. then would be /ex-path1 or /ex-path2 etc.

from slickstack.

jessuppi avatar jessuppi commented on May 28, 2024

Thanks for the suggestion @bari86

As per our discussion on Discord, I'm not opposed to adding this feature. However, over the past few years, every time someone has requested this feature and I've asked for a case example, it's always some poorly coded plugin that is not properly using the WooCommerce checkout, or something like that.

The case you shared in Discord was re: Cartflows, a type of funnel-building plugin that hacks WooCommerce cookies... my opinion is that such plugins are rather gimmicky and unstable, and not worthy of supporting. TLDR even if we added custom URL skip cache rules, I'm guessing there are going to be other conflicts with that plugin...

In other words I think the concept of custom URLs for skip cache is fine, but in practice I haven't seen a need for it. Rather than offering tons of jiggery hackery customization features, we've been really careful about things like this.

For example, if someone wants to skip cache on foreign language WooCommerce slugs, the "official" view of SlickStack is that we should add new rules for that language, and then hardcode it. In other words, using community feedback to determine changes to our hardcoded source vs. having dynamic features everywhere.

After several years and hundreds of clients using SlickStack (many with millions of sales per year) I've still never had a successful client require such customization.

from slickstack.

jessuppi avatar jessuppi commented on May 28, 2024

Still, at least for the purpose of debugging or emergency fixes, it's probably a good feature to add. So I think we can proceed with adding a custom skip cache feature on a sort of preliminary basis and see how it goes.

This will also need to keep in mind the foreign language slugs that are currently hardcoded in production block:

Ref: https://github.com/littlebizzy/slickstack/blob/master/modules/nginx/sites/production.txt

It might be a good idea to address both of these issues at the same time. For example, moving the language slugs into their own Nginx submodule files like /etc/nginx/conf.d/english.conf or whatever...

from slickstack.

jessuppi avatar jessuppi commented on May 28, 2024

This has been sitting for 2 years: #43

from slickstack.

jessuppi avatar jessuppi commented on May 28, 2024

Also see @backamblock comment on that thread:

suggestion:
ask about language in the installer script and link it to a file in your repository. everybody who needs a language should contribute the file with the correct translations.
Workaround for not yet accepted contributions: set own URL or path to language files in the ss-config

example file: "de_DE.txt"

from slickstack.

jessuppi avatar jessuppi commented on May 28, 2024

I mention this because we have discussed in the past defining custom URLs in ss-config for skip caching... and in the future, I'm guessing some users will want that feature directly in the WP Admin SlickStack dashboard.

But for now I guess the easiest solution is just dropping a file in /etc/nginx/conf.d/ with your desired skip cache rules, however I'm hoping we can standardize the filename at least.

We also need test to make sure all these (new) Nginx files are working together, since defining rules in submodules loads differently than with server blocks...

from slickstack.

jessuppi avatar jessuppi commented on May 28, 2024

Related:

#43

from slickstack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.