Giter Club home page Giter Club logo

Comments (2)

Goldziher avatar Goldziher commented on August 20, 2024

Hi there,

Well - werkzeug is huge, we dont need most of it, we just needed the multiparser, and I think we got everything else pretty much covered on our own end. I looked into Baize, which apparently has an uncredited port of the werkzeug multpart parser, and decided to simply make our own port.

Frankly, if werkzeug was modularized in a way that allowed us to simply incorporate some parts of it - I would have opted for that option for sure.

As for improvements - the code has updated typing, as you will note there isn't a single type: ignore comment in the repo, and some code has been refactored etc. to achieve this.

I also added slots, comments and simplified some stuff + added the async parser (https://github.com/starlite-api/starlite-multipart/blob/main/starlite_multipart/parser.py) and glued this to a datastructure I borrowed from Starlette (see datastructures).

Saying that, the core of the code is pretty much the same. I dont think it will be hard to extract my improvements out of it, with a simple git diff.

Can I invite you to checkout Starlite itself and perhaps join us?

from starlite-multipart.

pgjones avatar pgjones commented on August 20, 2024

Thanks, I'll take a look at the typing. Does using slots show a noticeable improvement here?

Can I invite you to checkout Starlite itself and perhaps join us?

I'm too busy with Pallets and Quart :p. However it is interesting to see what others are doing. You may be interested in Werkzeug's router as well. It won't perform as well as a radix tree, but will support all the features users expect.

from starlite-multipart.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.