[Bug]: disableColor option is ignored about listr2 HOT 4 CLOSED

Dear @teppeis,

This will be fixed on the next release and any option that uses this environment variable functionality is also not working properly, so I have to rethink how we can save this without doing a breaking change and turning the color into a function that gets called while listr class is constructing.

from listr2.

Dear @teppeis,

I have decided to disable this option since putting it in was kind of a mistake anyway. This will be released on v7.0.0+ but you can obtain the same behavior with using the underlying coloring libraries environment variables even though it does not have the same convenience/effect.

Since colorette has been used for a while and that should be true for version 4.0.0 as well you can use the environment variables FORCE_COLOR/NO_COLOR directly. If it does not work you can give it a try with the environment variable LISTR_DISABLE_COLOR which will be removed in v7. Setting this environment variables with anything should do the trick.

I am sorry for the inconvenience but the other way around is to always create a color palette whenever the Listr is going to use it. This was not very practical with the coloring library being used in constants as well so it had to be imported into the top level in a file which is exported by the index.js and would still be initialized before the environment variable was injected by the option.

It is still in beta so if you have any advice without making a huge changes that I am missing I can happily give it a try as well.

from listr2.

@cenk1cenk2
I agree with your decision.
I use NO_COLOR and find it reasonable.
It is a common mechanism for other tools and libraries.
Thank you.

from listr2.

No problem, thank you very much for reporting this.

It is always these "cute" things that I have not tested properly causes some problems :D

from listr2.