Giter Club home page Giter Club logo

Comments (5)

jlavado17 avatar jlavado17 commented on June 27, 2024 1

Will do that. Thank you so much for the help! 🙂

from docker-detect-secrets.

lirantal avatar lirantal commented on June 27, 2024

Does this PR provide you with any help to get the configuration you need sorted out? verdaccio/verdaccio#1373

from docker-detect-secrets.

lirantal avatar lirantal commented on June 27, 2024

I just tested locally on a project and seems to work fine on my end, maybe you need to pull a newer image?

docker run -it --rm --platform linux/amd64 --name detect-secrets --volume `pwd`:/usr/src/app lirantal/detect-secrets *
[scan]	INFO	Checking file: Dockerfile
[scan]	INFO	Checking file: LICENSE
[scan]	INFO	Checking file: README.md
[scan]	INFO	Checking file: app.js
[scan]	INFO	Skipping secret due to `detect_secrets.filters.heuristic.is_indirect_reference`.
[scan]	INFO	Skipping secret due to `detect_secrets.filters.heuristic.is_indirect_reference`.
[scan]	INFO	Skipping secret due to `detect_secrets.filters.heuristic.is_indirect_reference`.
[scan]	INFO	Skipping secret due to `detect_secrets.filters.heuristic.is_indirect_reference`.
[scan]	INFO	Skipping secret due to `detect_secrets.filters.heuristic.is_indirect_reference`.
[scan]	INFO	Skipping secret due to `detect_secrets.filters.heuristic.is_indirect_reference`.
[scan]	INFO	Skipping secret due to `detect_secrets.filters.heuristic.is_indirect_reference`.
[scan]	INFO	Skipping secret due to `detect_secrets.filters.heuristic.is_indirect_reference`.
[scan]	INFO	Skipping secret due to `detect_secrets.filters.heuristic.is_indirect_reference`.
[scan]	INFO	Skipping secret due to `detect_secrets.filters.heuristic.is_indirect_reference`.
[scan]	INFO	Skipping secret due to `detect_secrets.filters.heuristic.is_indirect_reference`.
[scan]	INFO	Skipping secret due to `detect_secrets.filters.heuristic.is_indirect_reference`.
[scan]	INFO	Skipping secret due to `detect_secrets.filters.heuristic.is_indirect_reference`.
[scan]	INFO	Skipping secret due to `detect_secrets.filters.heuristic.is_indirect_reference`.
[scan]	INFO	Skipping secret due to `detect_secrets.filters.heuristic.is_indirect_reference`.
[scan]	INFO	Skipping secret due to `detect_secrets.filters.heuristic.is_indirect_reference`.
[scan]	INFO	Skipping secret due to `detect_secrets.filters.heuristic.is_indirect_reference`.
[scan]	INFO	Skipping secret due to `detect_secrets.filters.heuristic.is_indirect_reference`.
[scan]	INFO	Skipping secret due to `detect_secrets.filters.heuristic.is_indirect_reference`.
[scan]	INFO	Skipping secret due to `detect_secrets.filters.heuristic.is_indirect_reference`.
[scan]	INFO	Skipping secret due to `detect_secrets.filters.heuristic.is_indirect_reference`.
[scan]	INFO	Skipping secret due to `detect_secrets.filters.heuristic.is_indirect_reference`.
[scan]	INFO	Checking file: app.json
[scan]	INFO	Checking file: deploy-heroku.md
[scan]	INFO	Checking file: docker-compose.yml

from docker-detect-secrets.

jlavado17 avatar jlavado17 commented on June 27, 2024

Hey, @lirantal thanks for taking the time to answer my question!

I didn't change anything and I'm not sure why but right now I'm not getting the is_invalid_file message anymore. But I do notice something, it is working using * and isn't when using "*".

But the thing is that it's working now! Did something change?

Also, what does this mean?

[scan]	INFO	Skipping secret due to `detect_secrets.filters.heuristic.is_indirect_reference`.

I'm testing and trying to commit a JavaScript file containing a fake secret and when I try to scan it I get that output. Is that expected? Should I be worried?

Thank you!

Edit:

Okay, I get it.

heuristic.is_indirect_reference | Primarily for KeywordDetector, filters secrets like secret = get_secret_key().

My file has secrets following that secret = get_secret_key() format and that's why it gets skipped.

But what if someone puts a direct reference to a secret inside that file and it gets skipped? How can I avoid that?

from docker-detect-secrets.

lirantal avatar lirantal commented on June 27, 2024

Happy to hear it's fixed and working for you :-)

About the CLI output message, you can refer to more of Yelp's repository for a more elaborate filters reference

from docker-detect-secrets.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.