Giter Club home page Giter Club logo

Comments (7)

fredewe avatar fredewe commented on August 15, 2024 1

@fuzzylogic2000 it would be nice if form fields are marked. But the solution we currently have did not cause any trouble so far i would say. So i would not put too much effort it in. What do you think @lthueer ?

from adhocracy-plus.

kleingeist avatar kleingeist commented on August 15, 2024

The _form.scss from meinBerlin is still imported to the product. but then some of the defintions are overwritten (see e.g. liqd/a4-product#208). especially :invalid is reset to the default input style.

we should copy the whole _form.scss to the product and adapt the styles there directly. as this can be much better understood then the overwrites.

from adhocracy-plus.

fuzzylogic2000 avatar fuzzylogic2000 commented on August 15, 2024

So currently, we only get the alert, but no red outline (or something like that) around the form field.
screenshot from 2019-03-01 11-23-51
@rittermo Do we want it like that?

from adhocracy-plus.

fuzzylogic2000 avatar fuzzylogic2000 commented on August 15, 2024

@rittermo What should happen here? Should the field in question have a red border to make clear, that that's where the error is happening? And should the text be left aligned or centered?

from adhocracy-plus.

fuzzylogic2000 avatar fuzzylogic2000 commented on August 15, 2024

@fredewe @lthueer Do we want the form fields that have errors to be marked? Currently errors are shown directly below, but the field is not marked.

from adhocracy-plus.

lthueer avatar lthueer commented on August 15, 2024

@fuzzylogic2000 @fredewe I agree! I think its fine for the moment how it is. Shall we close the issue then?

from adhocracy-plus.

fuzzylogic2000 avatar fuzzylogic2000 commented on August 15, 2024

yes, please!

from adhocracy-plus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.