Giter Club home page Giter Club logo

Comments (4)

lipp avatar lipp commented on May 21, 2024 1

adding redis would make login-with stateful...which would be sad :(
the user would loose the meta data on restart...

how about passing the meta with the redirect body on successful login. than your custom server could handle it?

... but this seems to complicated.... I think LW_GOOGLE_META is my favorite. it is explicit and simple. maybe you can come up with a nice env variable syntax?

from login-with.

lipp avatar lipp commented on May 21, 2024

Yeah, would be nice to have more details from the profile. But I'd prefer, not to waste too much cookie size [(limits)[http://browsercookielimits.squawky.net/]).

Maybe we could add an env like LW_MAX_COOKIE_SIZE which controls how much meta will be put.

Or the user should specify, additional meta fields should be included (per service), like LW_GOOGLE_META=foo.bar,baz[0].extra.url

Both solutions would require quite some boring work i guess....

from login-with.

luanmuniz avatar luanmuniz commented on May 21, 2024

How about adding a Redis instance to keep the data as optional? If the redis instance exist, keep the extra data in it, otherwise just ignore the extra data.

from login-with.

lipp avatar lipp commented on May 21, 2024

closing in favor of #44

from login-with.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.