Giter Club home page Giter Club logo

Comments (8)

lipoja avatar lipoja commented on May 26, 2024 1

@impredicative Thanks! Forgotten print is removed in 0.12.1.

from urlextract.

lipoja avatar lipoja commented on May 26, 2024 1

OK, closing issue. @Larrax can reopen it if some related bug is found.

Thanks @impredicative for testing! I should not do late night releases ...

from urlextract.

lipoja avatar lipoja commented on May 26, 2024

Thank you for reporting it, I have to debug it. Right now I can not tell what is causing this issue.

from urlextract.

impredicative avatar impredicative commented on May 26, 2024

@lipoja Hi, here is a simpler case of a missing URL:

>>> import urlextract
>>> urlextract.__version__
'0.11'
>>> url_extractor = urlextract.URLExtract()
>>> url_extractor.find_urls('https://google.com https://bing.com')
['https://google.com', 'https://bing.com']
>>> text = 'http://medicalxpress.com/news/2017-09-margarine-butter.html https://medicalxpress.com/news/2013-12-healthier-butter-ormargarine.html'
>>> url_extractor.find_urls(text)
['https://medicalxpress.com/news/2017-09-margarine-butter.html']

From the last command above, two URLs were expected, but only one was returned. To get all the URLs, I am having to use a workaround such as the one below:

>>> words = [word for word in text.split() if not word.isalnum()]
>>> [url for s in words for url in url_extractor.find_urls(s)]
['https://medicalxpress.com/news/2017-09-margarine-butter.html', 'https://medicalxpress.com/news/2013-12-healthier-butter-ormargarine.html']

Please investigate. Thanks.

from urlextract.

lipoja avatar lipoja commented on May 26, 2024

This issue should be fixed as part of 0.12.0 release

from urlextract.

impredicative avatar impredicative commented on May 26, 2024

Thanks. I confirm that at least my reported example is fixed with 0.12.0:

>>> import urlextract
>>> urlextract.__version__
'0.12.0'
>>> url_extractor = urlextract.URLExtract()
>>> url_extractor.find_urls('https://google.com https://bing.com')
['https://google.com', 'https://bing.com']
>>> text = 'http://medicalxpress.com/news/2017-09-margarine-butter.html https://medicalxpress.com/news/2013-12-healthier-butter-ormargarine.html'
>>> url_extractor.find_urls(text)
['http://medicalxpress.com/news/2017-09-margarine-butter.html', 'https://medicalxpress.com/news/2013-12-healthier-butter-ormargarine.html']

I also tested Larrax's example which too now works.

from urlextract.

impredicative avatar impredicative commented on May 26, 2024

@lipoja There is just the issue of the print line 624 in urlextract_core.py.

from urlextract.

impredicative avatar impredicative commented on May 26, 2024

I am satisfied. I will leave it to @Larrax to also test 0.12.1 and to maybe try to come up with any failing example if that is even possible.

from urlextract.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.