Temp directory as the 3rd fallback for TLDs cache file about urlextract HOT 6 CLOSED

As suggested in my pull request, I believe the best way is to use the python builtin tempfile, as it has no extra dependencies, and is well tested, and cross platform.

import tempfile
cache_dir=tempfile.gettempdir()

Do you see this replacing the home directory fallback, or as a second layer of fallback?

from urlextract.

For my use case its OK to have it as second option - replacing home. Maybe its better place than user's home. Its not that persistent (as you mentioned) but it is fine by me.

from urlextract.

Why not keep the files in a cache directory according to https://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html

There are a few packages which provide cross platform-ish xdg support

https://pypi.org/search/?q=xdg

The most commonly used is https://pypi.org/project/appdirs/

from urlextract.

Thank you for pointing it out.
I used appdirs for getting the user's cache dir.

from urlextract.

@lipoja

Trying to reopen an old ticket since there is a permission error on this implementation.

This line throws permission error when there is not enough privilege (tested in Linux):
https://github.com/lipoja/URLExtract/blob/master/urlextract/cachefile.py#L113

Write permission should be checked first before creating the cache directory.

Thanks!

from urlextract.

This reopened issue should be fixed in v0.14.0.

from urlextract.