Giter Club home page Giter Club logo

Comments (5)

linxGnu avatar linxGnu commented on August 24, 2024

@solaim please try to enable enquire_link. This way, connection are kept alive.

from gosmpp.

solaim avatar solaim commented on August 24, 2024

I try to dig code:

type SubmitSMResp struct {
	base
	MessageID string
}
// Marshal implements PDU interface.
func (c *SubmitSMResp) Marshal(b *ByteBuffer) {
	c.base.marshal(b, func(b *ByteBuffer) {
		b.Grow(len(c.MessageID) + 1)

		_ = b.WriteCString(c.MessageID)
	})
}
// Unmarshal implements PDU interface.
func (c *SubmitSMResp) Unmarshal(b *ByteBuffer) error {
	return c.base.unmarshal(b, func(b *ByteBuffer) (err error) {
		if c.CommandStatus == data.ESME_ROK {
			c.MessageID, err = b.ReadCString()
		}
		return
	})
}

what will happen when CommandStatus not ESME_ROK, MessageID is empty string, but In Marshal function, just

b.Grow(len(c.MessageID) + 1)

_ = b.WriteCString(c.MessageID)

maybe this is more better:

if len(c.MessageID) > 0 {
      b.Grow(len(c.MessageID) + 1)

      _ = b.WriteCString(c.MessageID)
}

from gosmpp.

linxGnu avatar linxGnu commented on August 24, 2024

@solaim good finding, I am making a fix here: #113
PTAL

from gosmpp.

solaim avatar solaim commented on August 24, 2024

LGTM

from gosmpp.

linxGnu avatar linxGnu commented on August 24, 2024

@solaim Thank you so much. I released a new version which includes above PR.

Please feel free to close this issue.

from gosmpp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.