Comments (10)
Optimally it would go as follows:
- If statement for does /config/modules directory exist
- If statement are build tools installed ? if not run apk commands to install them in container
- Build array of cpp files using
find
in the /config/modules directory ($MODULES) - ensure $MODULES array is not empty
- Build array of cpp files using
find
in the /usr/share/znc/modules directory ($INSTALLED) - For loop through the array of new modules (for MODULE in $MODULES; do ...)
- If statement in loop should compare the basename of the cpp file to the whole array of installed cpp files (
if [[ "$(basename "$MODULE")" != *"$INSTALLED"* ]]; then
) - run znc-buildmod and copy the directory to
/usr/share/znc/modules
On subsequent runs it should see that the module was already built and copied inside the container. If the user upgrades the container they will be rebuilt and copied. If it has already installed a module it will not do it again.
Let me know if any of this does not make sense.
from docker-znc.
How do you propose we handle this?
It sounds like you have a grasp on this, the logic could be an if statement that looks for a modules folder and installs build dependencies, then builds and moves the output to /usr/share/znc/modules
.
Are you interested in loop testing and creating a PR for something like this?
from docker-znc.
I'm not sure what's the best way of doing it in this case. From my understanding it's downloading the hardcoded modules, putting them into /tmp/znc/modules
and then running make
in /tmp/znc
to build all of that. I usually always did it with znc-buildmod
but I guess make also includes building the modules folder.
Maybe the steps would be:
mkdir -p \
/tmp/znc/modules
-
We could just
COPY
the content of/znc-config/modules
to/tmp/znc/modules
-
It'll download the default modules via curl like right now
-
Everything will be built here as usual https://github.com/linuxserver/docker-znc/blob/master/Dockerfile#L77
I'll have to give it a try and if that works will open a MR. Let me know if you see any obvious mistakes.
from docker-znc.
@dewey Any feedback on this?
from docker-znc.
@CHBMB I think it's would be a good strategy of doing it. Unfortunately I didn't have time to look at it myself yet and I always have it on my list. If someone else wants to go ahead with it that would be great but otherwise I'll see what I can do at some point.
from docker-znc.
@dewey We'll wait for you, nobody else has requested it, so I guess it's not a pressing change.
from docker-znc.
Something like #16 ?
from docker-znc.
(and also have no intent on changing that)
@dewey Could you explain? Did fix of znc/znc-docker#20 not work for you?
from docker-znc.
@DarthGandalf Sorry I don't remember that any more, that was a while ago and I'm currently not running ZNC :(
Thanks for following up though, if I set it up again I'll update it here.
from docker-znc.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
from docker-znc.
Related Issues (11)
- Add support for identd/oidentd HOT 3
- Include Fish.so module in docker HOT 2
- Add support for /Add module Clientbuffer HOT 7
- Add support for pointing to SSL certificate files through env vars HOT 6
- Add module clientaway HOT 3
- [FEAT] Nightly builds HOT 8
- [BUG] Source code is compiled with `--enable-python` indicating python support, but modpython refuses to load HOT 4
- Unable to access web interface -- Connection refused. HOT 2
- Unusable due to bugs on network adding step. Problem getting latest version ? HOT 7
- Not on Docker Hub HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docker-znc.