[BUG] <real_ip settings> about docker-snapdrop HOT 5 CLOSED

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

from docker-snapdrop.

Thanks for reporting this. I actually think our safest bet is to remove the mention of the real_ip configurations from the readme for this image. I do not think we should add the real_ip section back. There is no upstream (from snapdrop) documentation about this setting, so it was likely added by us at some point in the past. Recent internal discussions on the topic were cautious about including these settings by default more broadly.

I would recommend for now the best option is probably to use our CF real IP mod https://github.com/linuxserver/docker-mods/tree/swag-cloudflare-real-ip. Note that if you are using SWAG, this mod needs to be applied to SWAG as well as snapdrop (and any other nginx based container of ours that you need real IP reporting in).

from docker-snapdrop.

No i do not use swag and i am not sure how to implement this to be honest. I am very new to docker and docker compose

from docker-snapdrop.

It is possible to expose this application via this container directly to the internet, but we advise using a reverse proxy such as https://github.com/linuxserver/docker-swag

With or without SWAG, what you need to do with the mod is add an environment variable to your snapdrop container with the name DOCKER_MODS and the value linuxserver/mods:swag-cloudflare-real-ip and follow the usage instructions section of the readme https://github.com/linuxserver/docker-mods/tree/swag-cloudflare-real-ip#mod-usage-instructions applying the changes to your nginx.conf inside your snapdrop config folder.

from docker-snapdrop.

Bah, I removed it entirely!
Thanks for your time :)

from docker-snapdrop.