addon breaks other addons about ember-cli-bootstrap HOT 9 OPEN

Thanks @abuiles, I'll dig in to this when I get some time

from ember-cli-bootstrap.

@linstula thanks! btw this is only when env==production

from ember-cli-bootstrap.

Sorry, closed it by mistake.

from ember-cli-bootstrap.

@linstula quick update, I just nailed down the issue to the following lines in the index.js

    app.import(path.join(javascriptsPath, 'bs-core.max.js')); // Import bs-core first

    jsFiles.forEach(function(file) {
      var fileName = file.split('.')[0];
      app.import(path.join(javascriptsPath, fileName + '.max.js'));
    });

from ember-cli-bootstrap.

👍

from ember-cli-bootstrap.

@linstula is something around here https://github.com/dockyard/ember-cli-bootstrap/blob/master/vendor/ember-addons.bs_for_ember/dist/js/bs-core.max.js#L418

Edit: If I uncomment the following it works https://github.com/dockyard/ember-cli-bootstrap/blob/master/vendor/ember-addons.bs_for_ember/dist/js/bs-core.max.js#L420

from ember-cli-bootstrap.

@linstula The root of the problem is the following Ember.Handlebars.compile in https://github.com/dockyard/ember-cli-bootstrap/blob/master/vendor/ember-addons.bs_for_ember/dist/js/bs-core.max.js#L420

When running ember build --production ember-cli builds with handlebars.runtime.js which doesn't have .compile.

from ember-cli-bootstrap.

More info ember-addons/bootstrap-for-ember#87

from ember-cli-bootstrap.

I was under the impression that bootstrap_for_ember had resolved their issues with using Ember.Handlebars.compile. Thanks for tracking this down. I'll dig into it and see what can be done but likely wont have time until next week to do so.

from ember-cli-bootstrap.