@default and @none helpers not working properly on 1.6.0 version about dustjs-helpers HOT 12 CLOSED

Thanks for reporting and thanks for the simplified example! investigating.

from dustjs-helpers.

actually. can you elaborate on structure of data.

is it

{data: [{messages: ['a','b','c']},{messages: ['a','b','c']},{messages: ['a','b','c']}]}

or do yo have some nested thing with multiple "data" properties.

from dustjs-helpers.

seems to be related to eb10839. I'm still trying to get this reproduced.

from dustjs-helpers.

addSelectState seems like it'd be the culprit but we have tests around much of this stuff, so must be an edge case somewhere.

from dustjs-helpers.

confirmed the issue. we are dropping the tail context somewhere

here's a simplified test.

works in 1.5
fails in 1.6

+        name:     "select helper inside a array reaching outside",
+        source:   ["{#skills}{@select key=\"{.}\"}",
+                   "{@eq value=\"java\"}JAVA {outside},{/eq}",
+                   "{@eq value=\"js\"}JS {outside},{/eq}",
+                   "{@default value=\"foo\"}UNKNOWN {outside}{/default}",
+                   "{/select}{/skills}"].join("\n"),
+        context:  { "skills" : [ "java", "js" , "unknown"], "outside": 'foo' },
+        expected: "JAVA foo,JS foo,UNKNOWN foo",
+        message: "should test select helper inside a array with {.} and reaches outside"

from dustjs-helpers.

OK i found the issue.

context.rebase... doesn't do what you think it does. It takes a head and not a tail. the add function is adding a tail into a head which doesn't work.

from dustjs-helpers.

So I want context.stack.tail.head?

from dustjs-helpers.

nahh it's more annoying then that.

from dustjs-helpers.

There's a possible fix, but I want to look into it a bit more to make sure there aren't more edge cases.

from dustjs-helpers.

Yeah, this isn't enough. {$idx} has problems.

from dustjs-helpers.

There we go.

from dustjs-helpers.

1.6.1 released with a fix. Thank you again for the report!

from dustjs-helpers.