Giter Club home page Giter Club logo

Comments (1)

fxkr avatar fxkr commented on August 13, 2024 1

Thank you very much!

Implemented & released as version 1.0.9.

For the record, there were three things of note:

  1. The log group ARN's have an extra :* at the end. We're not the first ones to trip over it (aws/aws-cdk#18253). I think just stripping that away works for our purposes.
  2. The log group name supports a wider character set than some other resource types, like lambdas for example. I tested all possible special chars (based on the error message the console shows when trying to create a log group with an unsupported char); two chars need escaping in a particular way. I think this is a log group specific one off escaping mechanism so I handled it inline with search/replace. Of course I wrote a test that uses all possible special chars (based on a real ARN & URL from the AWS console).
  3. I learned that .replaceAll() is supported by the Nodejs v16 on my laptop, but not the older v14/v12 the tests in our Github actions use. So I went with .replace(/.../g, ...) which works anywhere as far as I know.

from link2aws.github.io.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.