Giter Club home page Giter Club logo

Comments (6)

 avatar commented on August 19, 2024

I think the sole purpose of this project should be to include those MicroG APKs that need signature spoofing.
All other modifications should be up to the LineageOS developers.
Keep it simple.

from android_prebuilts_prebuiltapks.

 avatar commented on August 19, 2024

This would be great, but they're not going to do it because it uses the same package name as the Chromium Webview that Lineage ships with.

lineageos4microg/docker-lineage-cicd#25

If they (Bromite devs) ever get around to changing the package name, then maybe they'll reconsider.

bromite/bromite#520

In the meantime, you can always fork the repo to include it yourself, and add a script in addon.d to automatically remove the original Chromium Webview when you flash the update zip (just in case, to prevent it from interfering with Bromite Webview.) turns out you can just do LOCAL_OVERRIDES_PACKAGES := webview and it should automatically override default AOSP webview.

from android_prebuilts_prebuiltapks.

 avatar commented on August 19, 2024

Note, though, that you might not actually need this. On Lineage, com.android.webview package name is whitelisted as a webview provider, regardless of signature. So you can delete /system/app/webview/webview.apk, then restart your phone, and it'll let you install Bromite webview as a user app via F-Droid. It doesn't need to be included as a built-in apk to work.

It might still be necessary to remove the original Chromium webview whenever you update the rom, some seem to say that this isn't necessary though. But just in case and to avoid potential issues, I'd remove it just so it can't interfere.

from android_prebuilts_prebuiltapks.

 avatar commented on August 19, 2024

I think the sole purpose of this project should be to include those MicroG APKs that need signature spoofing.
All other modifications should be up to the LineageOS developers.
Keep it simple.

This project already includes F-Droid which isn't part of the MicroG project. And while Lineage is updated daily, this project is updated once a month and the webview doesn't get updated for the entire time period. Using bromite would allow the user themselves to update the webview through F-Droid.
I'll close the issue since it seems to have already been discussed in another repo.

from android_prebuilts_prebuiltapks.

bananer avatar bananer commented on August 19, 2024

A less controversial solution for more frequent webview updates might be an F-Droid repository with daily/weekly signed builds of chromium-webview.

from android_prebuilts_prebuiltapks.

SebiderSushi avatar SebiderSushi commented on August 19, 2024

Note, though, that you might not actually need this. On Lineage, com.android.webview package name is whitelisted as a webview provider, regardless of signature. So you can delete /system/app/webview/webview.apk, then restart your phone, and it'll let you install Bromite webview as a user app via F-Droid. It doesn't need to be included as a built-in apk to work.

It might still be necessary to remove the original Chromium webview whenever you update the rom, some seem to say that this isn't necessary though. But just in case and to avoid potential issues, I'd remove it just so it can't interfere.

It should be woth noting that this has been fixed lately for supported LineageOS devices:
https://review.lineageos.org/c/LineageOS/android_frameworks_base/+/300878/

Basically the issue was that due this situation unsuspecting users trying to install let's say the Google WebView might accidentaly download & install a malicious APK that could act as a WebView provider on an untampered LineageOS. More about why exactly this is bad here.

The installation flow described by @Ammako still works but you'll have to place the Bromite WebView apk file into the /system/app/ directory for it to become a system app. That is, until the package name of the Bromite WebView gets changed.

from android_prebuilts_prebuiltapks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.