Giter Club home page Giter Club logo

Comments (8)

samwierema avatar samwierema commented on July 17, 2024

I've created an example fix in pull request #24. If you think that is the way to go, please do merge.

from line-bot-sdk-php.

moznion avatar moznion commented on July 17, 2024

Thank you for your suggestion and a patch. Looks cool!

However, I think it doesn't have to limit to Content-Type header. I feel it is better to be able to provide all of the header contents. That way, users of the SDK would be able to get any of the headers.

How do you think?

from line-bot-sdk-php.

moznion avatar moznion commented on July 17, 2024

@samwierema ping

from line-bot-sdk-php.

samwierema avatar samwierema commented on July 17, 2024

Yes, I think that might be helpful, although I can't necessarily tell why all headers are needed. Would you then also have methods for each header, or would you access them in a different way?

from line-bot-sdk-php.

moznion avatar moznion commented on July 17, 2024

Thank you.
I'll write PoC code to solve this problem, then could you review that?

from line-bot-sdk-php.

samwierema avatar samwierema commented on July 17, 2024

Yes, perfect. If you need any further input or feedback, let me know.

from line-bot-sdk-php.

moznion avatar moznion commented on July 17, 2024

I copy.

from line-bot-sdk-php.

moznion avatar moznion commented on July 17, 2024

Version 1.1.0 supports such functions!
https://github.com/line/line-bot-sdk-php/releases/tag/1.1.0

from line-bot-sdk-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.