Adapt HTTP/2 client about centraldogma-go HOT 7 CLOSED

I agree with you @minwoox 👍

Beside that, we need to add metric support, maybe via: https://github.com/armon/go-metrics. I will make a PR after new year holiday 🤔

from centraldogma-go.

Found that there's a way that the client can use h2c. So I think I can just replace to use HTTP/2 client. :)

from centraldogma-go.

@minwoox I really love your idea of creating new api (more New* methods) for additional HTTP/2 (with/without TLS) via h2c. The library is stable and easy to use: https://godoc.org/golang.org/x/net/http2#Transport

And it's also convenient if we let user pass his created-initialized client:

func New(client *http.Client)

So with HTTP/2 support like your suggestion, user has various way to initialize central dogma client. He could choose HTTP/1, HTTP/2 or passing their own http.Client 👍

from centraldogma-go.

func New(client *http.Client)

We definitely need this, I will add it, thank you!

As for the HTTP/1 and HTTP/2, I was going to leave the HTTP/1 client.
But it turns out that Golang supports h2c as well, so we can do both cleartext and encrypted communication using HTTP/2.
Because of that, I couldn't find a reason to keep the HTTP/1 client. Central Dogma server supports HTTP/2 and a user uses this client only to communicate with the server. So I want to completely remove it.
Please let me know if we have to keep it or not.

from centraldogma-go.

OK to support HTTP/2 only IMO, although it'd be nice to have HTTP/1 support.

from centraldogma-go.

I will make a PR after new year holiday 🤔

Great. I'm looking forward to it. 👍

from centraldogma-go.

Fixed via #20

from centraldogma-go.