Comments (4)
Thanks for the additional context here @ellemouton. I also agree that Stop
shouldn't be exposed over LNC. We'd still like to have a way to get the litd
version in addition to faraday so I'd like to add that as a TODO as well.
from lightning-node-connect.
I'm wondering if it would make more sense to include version numbers in the subserver RPC instead of exposing GetInfo
?
It looks like GetInfo
only returns version information for litd
:
If the subserver status server returned version information for all subservers it would be a lot more useful for feature detection for loop, pool, etc. not just lit
from lightning-node-connect.
The issue is on the LiT side. Currently we dont expose Proxy
calls over LNC since it would also expose things like Stop
. So either we just say we are ok with the user being able to call Stop
over LNC if they have an admin session in which case this is an easy fix on the LiT side. Otherwise we should consider splitting up the Proxy service a bit.
from lightning-node-connect.
If the subserver status server returned version information for all subservers it would be a lot more useful for feature detection for loop, pool, etc. not just lit
I think these are already queryable directly though? Pool, Loop and Taproot-assets all have a GetInfo
call. So those can just be called directly. So the only TODO here imo is adding a GetInfo
to faraday
from lightning-node-connect.
Related Issues (20)
- crypto: implement encryption/decryption with safe nonce
- WebSocket closed: unclean connection close: status = StatusAbnormalClosure HOT 1
- noise layer: allow authData payload size to be dynamic HOT 1
- LiT integration: bake and use super macaroon HOT 2
- itests: expand end to end test suite to include node.js process with a wasm connection
- Generalization of the protocol?
- Connectivity problems after v0.1.6 update HOT 4
- Detect expired session HOT 3
- build: investigate shrinking WASM blob size using tiny-go HOT 7
- `WebAssembly.instantiateStreaming` fails in example file HOT 4
- New tag for LNC
- Cannot reconnect after disconnect HOT 1
- Unable to connect. HOT 19
- Fails to reconnect using pairing phrase
- Lightning Node Connect does not work with wasmer HOT 8
- we need a python module HOT 5
- Unable to reconnect to node via LNC when network connection was down (e. g. airplane mode was on) HOT 3
- [Bug] Connection on Mobile Browser Failing
- itest: CI often fails with "predicate not satisfied after time out" error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lightning-node-connect.