Giter Club home page Giter Club logo

Comments (4)

jamaljsr avatar jamaljsr commented on August 28, 2024 1

Thanks for the additional context here @ellemouton. I also agree that Stop shouldn't be exposed over LNC. We'd still like to have a way to get the litd version in addition to faraday so I'd like to add that as a TODO as well.

from lightning-node-connect.

itsrachelfish avatar itsrachelfish commented on August 28, 2024

I'm wondering if it would make more sense to include version numbers in the subserver RPC instead of exposing GetInfo?

It looks like GetInfo only returns version information for litd:

Screenshot from 2023-09-14 12-53-28

If the subserver status server returned version information for all subservers it would be a lot more useful for feature detection for loop, pool, etc. not just lit

from lightning-node-connect.

ellemouton avatar ellemouton commented on August 28, 2024

The issue is on the LiT side. Currently we dont expose Proxy calls over LNC since it would also expose things like Stop. So either we just say we are ok with the user being able to call Stop over LNC if they have an admin session in which case this is an easy fix on the LiT side. Otherwise we should consider splitting up the Proxy service a bit.

from lightning-node-connect.

ellemouton avatar ellemouton commented on August 28, 2024

If the subserver status server returned version information for all subservers it would be a lot more useful for feature detection for loop, pool, etc. not just lit

I think these are already queryable directly though? Pool, Loop and Taproot-assets all have a GetInfo call. So those can just be called directly. So the only TODO here imo is adding a GetInfo to faraday

from lightning-node-connect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.