Comments (8)
I have been recklessly running master since launching the node. :)
from faraday.
I tested #53. I can pull a default node report now.
from faraday.
Thanks for reporting!
We're currently looking at payment hops to detect whether we have made a payment or ourselves (in the hope of identifying circular rebalances). We needed to look at hops rather than payment request because we don't always have payment request present, but I think it would make sense to fall back to checking the payment request for a destination in this case. If we have neither, I think logging a warning and just accepting that some old circular payments may not be detected is ok.
In the meantime, you should be able to get around the issue by running nodereport
with a specific start date that is after this payment.
from faraday.
When I try with different start dates I still get errors.
After the last hopless payment:
$ frcli nodereport --start_time 1533081600
[frcli] rpc error: code = Unknown desc = period too long for granularity level
And from the beginning of this month.
$ frcli nodereport --start_time 1590969600
[frcli] rpc error: code = Unknown desc = payment htlc has a route with zero hops
from faraday.
period too long for granularity level
Ah, I know what's going on here. Will get a fix up asap. Basically the api we use to get fiat estimates from has a tradeoff between accuracy of data and the length of time you query for. It's currently hardcoded which isn't good, I'll update it to shift this "granularity" with the length of query.
Unknown desc = payment htlc has a route with zero hops
I am intrigued that you have a payment with no htlcs which has zero hops from the last month. Have you recently upgraded? Also going to put the fix in for this, but I am curious.
from faraday.
If you know which payment is tripping you up, could you find it in listpayments
for me and post the output? I just want to make sure that the fix I put up covers this case.
I don't need payment hash/amount or any identifiable fields, so feel free to remove that info. Specifically interested in the payment status, creation time and the list of htlcs (if it's there).
"status": "?",
"creation_time_ns":
"htlcs": [list of htlcs, if present],
from faraday.
The last payment with an empty set of hops is
"SUCCEEDED"
"1531397351000000000"
{
"status": "SUCCEEDED",
"route": {
"total_time_lock": 0,
"total_fees": "0",
"total_amt": "X000",
"hops": [],
"total_fees_msat": "0",
"total_amt_msat": "X000000"
},
"attempt_time_ns": "0",
"resolve_time_ns": "0",
"failure": null,
"preimage": "00000000000000000000000000000XXX"
}
from faraday.
Awesome, thanks for the output! Fix is in #53, I'll update the issue once it's merged.
You'll see a warning `payment: {hash} destination unknown" in your logs once the fix is merged. For these payments where we don't know the destination (because they have no hops), we might not pick up circular payments properly (they'll just look like regular payments). Other than that, the report will be unaffected.
from faraday.
Related Issues (20)
- openchannel with pushsats isn't accounted for HOT 3
- Allow for custom price API HOT 4
- Audit fails if AMP invoices are present
- Unable to install - schwanenlied.me not found. HOT 2
- Signet support
- No outliers reported
- Report fees for onchain transactions that split UTXOs HOT 1
- 404 link to Harmony Reporting Standard HOT 1
- tls.cert path doesn't work HOT 3
- multi: node fitness tracking
- itest: fix issues caused by the bump to lnd 0.15.4-beta
- Bug: Can't send custom_prices over REST protocol HOT 3
- Include txid in exported cost list CSV file HOT 1
- Provide a docker image on dockerhub HOT 4
- config: clarify host/port for bitcoind config HOT 8
- ResourceExhausted error while running the Node Audit HOT 3
- Include invoice description from outgoing payments in audit notes
- TLS certificate validity period should be configurable
- Should provide flag for using system TLS certs
- Unable to define --macaroonpath when starting service HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from faraday.