NLTK being loaded on image classifcation about lightning-flash HOT 8 CLOSED

@aribornstein can you paste the error? and explain intended behaviour?

from lightning-flash.

The error is already pasted

[nltk_data] Error loading punkt: <urlopen error [Errno -3] Temporary
[nltk_data] failure in name resolution>

If I'm not using a NLP Task it makes no sense to load NLTK.

from lightning-flash.

I would like to fix this.

from lightning-flash.

Hi @aribornstein, since __init__.py of flash imports all the modules, the text module is also imported and nltk.download("punkt", quiet=True) is executed. This download should happen only when someone uses the library for the first time.

https://github.com/PyTorchLightning/lightning-flash/blob/202717d888fccb934dcc4507d22542d7cf71de96/flash/text/seq2seq/summarization/utils.py#L21

from lightning-flash.

Is there a way to only load if using the task?

from lightning-flash.

@edenlightning one thing I've been noticing is that some tasks like ImageClassification have pretrained weights set to True by default. Not sure if this can be related but the underlying libraries providing the backbones like torchvision have it to False I guess to avoid auto-downloading issues.

from lightning-flash.

@aniketmaurya Would you like to do a PR for this?

from lightning-flash.

Yes @kaushikb11 I'd love to add a PR for this.

from lightning-flash.