Comments (2)
Hi @tanhevg, thanks for raising this issue and sorry for the slow response from my side.
The overall problem was that when calculating the auc in the plot method of PrecisionRecallCurve
there was a assumption that the x
input of the curve is in ascending order but for PR-curve it is in descending order. This should be taken care of now. This should make sure that regardless of method of what way you calculate the area the values will be similar.
However, there will still be a difference in the values compared to BinaryAveragePrecision
. The reason for this is that BinaryAveragePrecision
uses one type of curve interpolation (as stated in the docs) whereas for PrecisionRecallCurve
it uses the trapezoidal rule which will give difference in value.
For the example provided the updated code gives
Class 0 | Class 1 | |
---|---|---|
BinaryAveragePrecision | 0.18 | 0.96 |
MulticlassPrecisionRecallCurve | 0.16 | 0.96 |
I added some notes about this to the documentation in PR #2437 which also mentions the fix above.
from torchmetrics.
Thanks for the update, @SkafteNicki . Minor discrepancies between AUROC and BinaryAveragePrecision
should not be a problem.
Does the PR also add labels to the axes? I had a quick look at the changes and I don't think it does. It is a bit confusing now, especially after the axes were swapped between v1.2.1
and v1.3.1
Also, there are no changes to the tests in the PR, meaning nothing prevents this or similar issues from reappearing in the future.
from torchmetrics.
Related Issues (20)
- Error in ERGAS metric HOT 5
- top-k multiclass macro accuracy less than top-1 multiclass macro accuracy HOT 2
- top-k multiclass macro accuracy is not calculated correctly
- Error during argument validation: predictions can not contain `ignore_index` HOT 1
- Add a CW-SSIM support for torchmetrics HOT 8
- Create gallery of realistic examples
- Delay imports of optional dependencies such as torchaudio, torchvision HOT 1
- Incorrect result in computing `MulticlassRecall` macro average when `ignore_index` is specified HOT 1
- RetrievalNormalizedDCG doesn't change with different top_k values HOT 2
- BootStrapper.update/forward don't process kwargs HOT 1
- List Metric synchronization fails in corner case HOT 1
- Contribution: Add new audio/speech metrics for generative audio HOT 4
- ClasswiseWrapper and JaccardIndex confmat attribute error HOT 2
- MulticlassAveragePrecision crashes on .compute() if empty HOT 2
- Metric not moved to device and invalids the cpu-gpu offloading when combining with DeepSpeed HOT 1
- [Bug] No backend type associated with device type cpu HOT 2
- Metrics not being logged properly on remote GPU HOT 4
- Retrieval Metrics GPU Memory Leak HOT 4
- Specificity if TN + FN = 0 HOT 1
- Building the docs HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from torchmetrics.