Giter Club home page Giter Club logo

Comments (2)

SkafteNicki avatar SkafteNicki commented on June 25, 2024

Hi @tanhevg, thanks for raising this issue and sorry for the slow response from my side.
The overall problem was that when calculating the auc in the plot method of PrecisionRecallCurve there was a assumption that the x input of the curve is in ascending order but for PR-curve it is in descending order. This should be taken care of now. This should make sure that regardless of method of what way you calculate the area the values will be similar.

However, there will still be a difference in the values compared to BinaryAveragePrecision. The reason for this is that BinaryAveragePrecision uses one type of curve interpolation (as stated in the docs) whereas for PrecisionRecallCurve it uses the trapezoidal rule which will give difference in value.
For the example provided the updated code gives

Class 0 Class 1
BinaryAveragePrecision 0.18 0.96
MulticlassPrecisionRecallCurve 0.16 0.96

I added some notes about this to the documentation in PR #2437 which also mentions the fix above.

from torchmetrics.

tanhevg avatar tanhevg commented on June 25, 2024

Thanks for the update, @SkafteNicki . Minor discrepancies between AUROC and BinaryAveragePrecision should not be a problem.

Does the PR also add labels to the axes? I had a quick look at the changes and I don't think it does. It is a bit confusing now, especially after the axes were swapped between v1.2.1 and v1.3.1

Also, there are no changes to the tests in the PR, meaning nothing prevents this or similar issues from reappearing in the future.

from torchmetrics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.