Giter Club home page Giter Club logo

Comments (4)

awaelchli avatar awaelchli commented on May 13, 2024 1

@carmocca we should be careful recommending such step methods. Currently, I would advise only going through forward() in Fabric. Due to the technical limitations of the ddp wrapper (which only wraps forward). The LM integration in Fabric has this issue Lightning-AI/pytorch-lightning#16856.

from lit-llama.

rasbt avatar rasbt commented on May 13, 2024 1

To be honest, I would just remove it if it's not used. There is no downside of removing it, and it would (slightly) aid the overall goal of having a minimal, readable implementation.

from lit-llama.

lantiga avatar lantiga commented on May 13, 2024

My bad, it’s a remnant from nanoGPT :-)

from lit-llama.

carmocca avatar carmocca commented on May 13, 2024

It could be used in the training scripts if we want to

from lit-llama.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.