Giter Club home page Giter Club logo

Comments (5)

williamFalcon avatar williamFalcon commented on May 5, 2024 3

live on master now

from lightning.

williamFalcon avatar williamFalcon commented on May 5, 2024

great idea. val call can just be made optional! very easy to do.

do you want to give it a shot?

  1. remove notimplemented warning. add pass instead. (from validation_step)
  2. allow get val_dataloader to be none.
  3. in val loop check if val_loader is none (at very beginning). return if it is none.

from lightning.

tc-wolf avatar tc-wolf commented on May 5, 2024

Thanks, I'll take a stab at that this weekend!

from lightning.

singularperturbation avatar singularperturbation commented on May 5, 2024

Dang, too fast for me :) Thanks for working on this!

from lightning.

pamparana34 avatar pamparana34 commented on May 5, 2024

Sorry for writing to this thread but how can I use it in my model? Is it enough to do something like:

@pl.data_loader
def val_dataloader(self):
     if has_valset:        
        return self.__dataloader(train=False)
    
    # No validation set
    return None

After that do I need to do something like:

def validation_step(self, batch, batch_idx):
    # Is this check necessary?
    if not has_vaset:
        return
   
   # process the validation batch

from lightning.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.