Giter Club home page Giter Club logo

Comments (5)

williamFalcon avatar williamFalcon commented on May 5, 2024

@Borda ok. Unfortunately i'm on a really tight research agenda. I took a lot of time already to make sure the coverage was solid and up to 99%. I don't have time to figure out this codecov thing and it's a bit of engineering overhead right now which is detracting from research.

If this method doesn't work today, we'll roll back to standard coverage and the config file for that. But I don't want to add unnecessary engineering overhead that isn't 100% complete into the package.

Let me know what you think. Thanks!

from lightning.

williamFalcon avatar williamFalcon commented on May 5, 2024

@Borda ok, it's stable now and the correct coverage shows (through the .svg badge). if you get the command-line submit working to codecov then great, we can use it as long as it's accurate.

otherwise, let's stick to the badge for now and move on to adding other cool features everyone's been asking about #50 #49

from lightning.

Borda avatar Borda commented on May 5, 2024

Ignore files should be specified in codecove run not in the codecov config
Ok I don't mind to keep your svg badge for now since there are some complication with the Automatic one... My point was just that in future it would better to have automatic one and in the time I was proposing it I didn't know about the limitations with GPU...
Just I would move the svg badge to docs folder...

from lightning.

williamFalcon avatar williamFalcon commented on May 5, 2024

agreed. moved and updated

from lightning.

Borda avatar Borda commented on May 5, 2024

Also, it seems that you have a syntax error in your Codecov.yaml

curl --data-binary @.codecov.yml https://codecov.io/validate

see https://docs.codecov.io/docs/codecov-yaml

from lightning.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.