java.nio.file.FileSystemException: Incorrect function about jardiff HOT 5 CLOSED

maybe @retronym will have some insight

a few things you might try in the hopes of producing clues as to the scope and nature of the problem:

• downgrade to Java 11 or 8, or upgrade to 17
• try it on Linux or MacOS, perhaps it's some Windows-specific issue

also, I have to ask: does jardiff work at all for you on your setup? is the problem specific to the particular JARs you want to analyze, or is it broken no matter what JARs you run it on?

from jardiff.

jardiff is trying to create a file to write the rendered output.

https://github.com/scala/jardiff/blob/main/core/src/main/scala/scala/tools/jardiff/JarDiff.scala#L106

https://github.com/scala/jardiff/blob/0c6a7bd0eb00cf9838a90e2072ca7f1a315277a2/core/src/main/scala/scala/tools/jardiff/AsmTextifyRenderer.scala#L29

You could try jardiff -g C:/path/without/spaces to rule out some issue with the default temp directory being in a file systenm, or part of a file system that is related to the bug

from jardiff.

It's error number one, so it must be the first thing that can go wrong.

ERROR_SUCCESS

0 (0x0)

The operation completed successfully.

ERROR_INVALID_FUNCTION

1 (0x1)

Incorrect function.

ERROR_FILE_NOT_FOUND

2 (0x2)

The system cannot find the file specified.

https://docs.microsoft.com/en-us/windows/win32/debug/system-error-codes--0-499-

from jardiff.

The dir jardiff-16971073125157135731 got created but there are no files in it besides another .git subdir. The file path above doesn't have spaces in it.

So it appears to fail at the 1st attempt to create a file.

I just realized the file name is "con" which is verboten on Windows (regardless of capitalization) unless you use the unfiltered I/O driver. cON.class.asm

It's a somewhat standard trick done by some obfuscators.

You could perhaps use paths starting with \\?\ (on Windows) which fixes that (as well as removing the 260-chars path limit), but this obfuscator is also "smart" enough to create capitalization-based conflicts on Windows (like also having a different class file called just con.class), which is not resolved by \\?\.

In the meantime I've used IntelliJ to do the jar comparison, which does it in-memory, so it doesn't run into such issues on Windows.

from jardiff.

ahhh, our old friend con, who pops up every so often and bites somebody. glad you sorted it out

from jardiff.